MRF issueshttps://gitlab.inria.fr/pacanows/MRF/-/issues2021-07-05T11:24:29+02:00https://gitlab.inria.fr/pacanows/MRF/-/issues/204Refactoring SceneParser2021-07-05T11:24:29+02:00PACANOWSKI RomainRefactoring SceneParser
Move XML parsing methods from SceneParser to another class
XMLParser.cpp
XMLParser.hpp
this way specific parsers will be able to use generic functions (e.g., retrieveColor(...) ).
A parser for Geometry should be also added.
A specif...
Move XML parsing methods from SceneParser to another class
XMLParser.cpp
XMLParser.hpp
this way specific parsers will be able to use generic functions (e.g., retrieveColor(...) ).
A parser for Geometry should be also added.
A specific parser for Ply as wellMalia 1.3MURRAY DavidMURRAY Davidhttps://gitlab.inria.fr/pacanows/MRF/-/issues/197Move termcolor in externals/2021-03-26T14:51:40+01:00PACANOWSKI RomainMove termcolor in externals/The file termcolor.hpp
should probably moved to externals and removed from TestingThe file termcolor.hpp
should probably moved to externals and removed from Testinghttps://gitlab.inria.fr/pacanows/MRF/-/issues/157Tonemapping operators2020-11-04T23:19:06+01:00Alban FichetTonemapping operatorsCurrently, the Reinhard tonemapping operator is within `color.hpp`.
It may be a good idea to create a separate module for tonemapping operators. Then, how shall it be accessed ?
# 1 - Static methods?
```
class Tonemapper {
public:
sta...Currently, the Reinhard tonemapping operator is within `color.hpp`.
It may be a good idea to create a separate module for tonemapping operators. Then, how shall it be accessed ?
# 1 - Static methods?
```
class Tonemapper {
public:
static Color reinhard05(
Color const & color,
float const & chromatic_adaptation,
Color const & means,
float const & lum_mean,
float const & light_adaptation,
float const & contrast,
float const & intensity);
};
```
# 2 - Abstract tonemapper?
```
class Tonemapper {
public:
virtual Color apply(Color const& color) const = 0;
};
class Reinhard05 : public Tonemapper {
public:
Reinhard05(
float const & chromatic_adaptation,
Color const & means,
float const & lum_mean,
float const & light_adaptation,
float const & contrast,
float const & intensity);
virtual Color apply(Color const& color) const;
};https://gitlab.inria.fr/pacanows/MRF/-/issues/143Code Cleaning from MRF22020-11-04T23:21:58+01:00PACANOWSKI RomainCode Cleaning from MRF2# Useless class and functions
We list here the class and functions that were imported from the previous version of MRF and are never used
in this version but still present in the code base.
- material builder# Useless class and functions
We list here the class and functions that were imported from the previous version of MRF and are never used
in this version but still present in the code base.
- material builderhttps://gitlab.inria.fr/pacanows/MRF/-/issues/140Reminder Methods from MRF2 not working anymore2020-11-04T23:22:29+01:00PACANOWSKI RomainReminder Methods from MRF2 not working anymore# Scene object
These method aren't working anymore:
- totalIntersectionCost
- totalGeometryCost
- verifyBRDF in SPECTRAL MODE
- recomputeAABBox# Scene object
These method aren't working anymore:
- totalIntersectionCost
- totalGeometryCost
- verifyBRDF in SPECTRAL MODE
- recomputeAABBoxhttps://gitlab.inria.fr/pacanows/MRF/-/issues/39CLEAN render_ggx_folder.py2020-11-04T23:20:53+01:00PACANOWSKI RomainCLEAN render_ggx_folder.pyOld script that needs some cleaning.
Still usefulOld script that needs some cleaning.
Still usefulPACANOWSKI RomainPACANOWSKI Romain