From 9bd8c60487046a3ae6ce11e50ca9fe89b45e29ee Mon Sep 17 00:00:00 2001 From: laurent-garnier <laurent.garnier@univ-rennes1.fr> Date: Fri, 1 Dec 2023 11:50:11 +0100 Subject: [PATCH 1/4] add definition to remove override --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 20c85c3..4177b6b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -105,6 +105,8 @@ set(OV_CONFIG_SUBDIR "${PROJECT_NAME}-${PROJECT_VERSION}" CACHE STRING "Subdirec set(OVT_TEST_DATA_DIR "${CMAKE_SOURCE_DIR}/test-data") +# Remove deprecated warnings related to override functions +#add_definitions(-Wno-inconsistent-missing-override) # Options option(Flag_VerboseOutput "Verbose CMake output" OFF) -- GitLab From ad8a8ca0971910a9d320511a7605adb300c0b403 Mon Sep 17 00:00:00 2001 From: laurent-garnier <laurent.garnier@univ-rennes1.fr> Date: Fri, 1 Dec 2023 12:07:43 +0100 Subject: [PATCH 2/4] activate definition to remove override --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4177b6b..9082c04 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -106,7 +106,7 @@ set(OV_CONFIG_SUBDIR "${PROJECT_NAME}-${PROJECT_VERSION}" CACHE STRING "Subdirec set(OVT_TEST_DATA_DIR "${CMAKE_SOURCE_DIR}/test-data") # Remove deprecated warnings related to override functions -#add_definitions(-Wno-inconsistent-missing-override) +add_definitions(-Wno-inconsistent-missing-override) # Options option(Flag_VerboseOutput "Verbose CMake output" OFF) -- GitLab From ef17fac4635ac079ce1e48acdaea5368738bea2c Mon Sep 17 00:00:00 2001 From: GARNIER Laurent <laurent.garnier@irisa.fr> Date: Mon, 4 Dec 2023 16:12:46 +0000 Subject: [PATCH 3/4] Not for Windows --- CMakeLists.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9082c04..4892283 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -105,8 +105,10 @@ set(OV_CONFIG_SUBDIR "${PROJECT_NAME}-${PROJECT_VERSION}" CACHE STRING "Subdirec set(OVT_TEST_DATA_DIR "${CMAKE_SOURCE_DIR}/test-data") -# Remove deprecated warnings related to override functions -add_definitions(-Wno-inconsistent-missing-override) +if (UNIX) + # Remove deprecated warnings related to override functions + add_definitions(-Wno-inconsistent-missing-override) +endif() # Options option(Flag_VerboseOutput "Verbose CMake output" OFF) -- GitLab From 07c40bdd2f2a4ea83db12fd7009e9a26f6c55e05 Mon Sep 17 00:00:00 2001 From: laurent-garnier <laurent.garnier@univ-rennes1.fr> Date: Fri, 15 Dec 2023 11:23:42 +0100 Subject: [PATCH 4/4] remove flag --- CMakeLists.txt | 5 ----- 1 file changed, 5 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4892283..5d1825b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -105,11 +105,6 @@ set(OV_CONFIG_SUBDIR "${PROJECT_NAME}-${PROJECT_VERSION}" CACHE STRING "Subdirec set(OVT_TEST_DATA_DIR "${CMAKE_SOURCE_DIR}/test-data") -if (UNIX) - # Remove deprecated warnings related to override functions - add_definitions(-Wno-inconsistent-missing-override) -endif() - # Options option(Flag_VerboseOutput "Verbose CMake output" OFF) option(OV_DISPLAY_ERROR_LOCATION "display complete error locations" ON) -- GitLab