From 49a5f26b5f2342e55ccef7221b8af99d0ee3281d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Euzenat?= <Jerome.Euzenat@inria.fr> Date: Tue, 12 Oct 2010 10:03:49 +0000 Subject: [PATCH] - cleaned up comments --- src/fr/inrialpes/exmo/align/impl/BasicParameters.java | 4 ++-- src/fr/inrialpes/exmo/align/impl/eval/PRGraphEvaluator.java | 5 ++--- .../exmo/align/impl/eval/ThresholdGraphEvaluator.java | 2 +- src/fr/inrialpes/exmo/align/parser/RDFParser.java | 6 +----- src/fr/inrialpes/exmo/align/parser/XMLParser.java | 1 - 5 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/fr/inrialpes/exmo/align/impl/BasicParameters.java b/src/fr/inrialpes/exmo/align/impl/BasicParameters.java index 4023a8ab..1852c897 100644 --- a/src/fr/inrialpes/exmo/align/impl/BasicParameters.java +++ b/src/fr/inrialpes/exmo/align/impl/BasicParameters.java @@ -48,14 +48,14 @@ import org.semanticweb.owl.align.Parameters; * By default and for means of communication, parameter names and values * are Strings (even if their type is Object). * - * [JE:2010] A note about unchecked warnings + * A note about unchecked warnings * java.util.Properties is declared as hashtable<Object,Object> * However all its accessors can only put String as key in the hashtable * But propertyNames returns Enumeration and not Enumeration<String> * Using keySet will not change anything, because it will be Set<Object> * Java 6 introduces Set<String> stringPropertyNames() !! * - * [JE:2010] This class implements Parameters for compatibility purposes. + * This class implements Parameters for compatibility purposes. * Parameters is only "morally" deprecated in the Alignment API, but it is * not used anymore. * diff --git a/src/fr/inrialpes/exmo/align/impl/eval/PRGraphEvaluator.java b/src/fr/inrialpes/exmo/align/impl/eval/PRGraphEvaluator.java index ce023eb3..5fb62cbc 100644 --- a/src/fr/inrialpes/exmo/align/impl/eval/PRGraphEvaluator.java +++ b/src/fr/inrialpes/exmo/align/impl/eval/PRGraphEvaluator.java @@ -60,8 +60,7 @@ import java.net.URI; * Otherwise, it would basically be: * SUM_c\in correct( P( c ) ) / nbexpected * - * NOTE (JE:2010): This should be adapated for other notions of Precision and Recall - * This is fully possible and will be done with + * NOTE: This should be adapated for other notions of Precision and Recall * */ @@ -87,7 +86,7 @@ public class PRGraphEvaluator extends GraphEvaluator { * Compute precision and recall graphs. */ public Vector<Pair> eval( Properties params ) { // throws AlignmentException - points = new Vector<Pair>(STEP+1); // 2010evaluate the size + points = new Vector<Pair>(STEP+1); if ( params != null && params.getProperty( "oldstyle" ) != null ) { return evalOldStyle(); diff --git a/src/fr/inrialpes/exmo/align/impl/eval/ThresholdGraphEvaluator.java b/src/fr/inrialpes/exmo/align/impl/eval/ThresholdGraphEvaluator.java index 2cde1979..a5226c3a 100644 --- a/src/fr/inrialpes/exmo/align/impl/eval/ThresholdGraphEvaluator.java +++ b/src/fr/inrialpes/exmo/align/impl/eval/ThresholdGraphEvaluator.java @@ -75,7 +75,7 @@ public class ThresholdGraphEvaluator extends GraphEvaluator { * */ public Vector<Pair> eval( Properties params ) { // throws AlignmentException - points = new Vector<Pair>(STEP+1); // 2010evaluate the size + points = new Vector<Pair>(STEP+1); opt = 0.; int nbcorrect = 0; int nbfound = 0; diff --git a/src/fr/inrialpes/exmo/align/parser/RDFParser.java b/src/fr/inrialpes/exmo/align/parser/RDFParser.java index 3c940b76..5a0c2ec4 100644 --- a/src/fr/inrialpes/exmo/align/parser/RDFParser.java +++ b/src/fr/inrialpes/exmo/align/parser/RDFParser.java @@ -149,16 +149,12 @@ public class RDFParser { public static void initSyntax() { if ( rDFModel == null ) { rDFModel = ModelFactory.createDefaultModel(); - // The register is always initialised? for ( SyntaxElement el : SyntaxElement.values() ) { - // JE2010 This is incorrect because there can be Resources (classes) - // and/or Property ... They may all be resources... if ( el.isProperty == true ) { el.resource = rDFModel.createProperty( el.id() ); } else { el.resource = rDFModel.createResource( el.id() ); } - //register.put( el.getName(), el ); } } } @@ -441,7 +437,7 @@ public class RDFParser { rdfType.equals( SyntaxElement.PROPERTY_VALUE_COND.resource ) ) { result = parseProperty( node ); } else if ( rdfType.equals( SyntaxElement.RELATION_EXPR.resource ) || - rdfType.equals( SyntaxElement.RELATION_DOMAIN_COND.resource ) || // JE 2010: no chance + rdfType.equals( SyntaxElement.RELATION_DOMAIN_COND.resource ) || // no chance rdfType.equals( SyntaxElement.RELATION_CODOMAIN_COND.resource ) ) { result = parseRelation( node ); } else if ( rdfType.equals( SyntaxElement.INSTANCE_EXPR.resource ) ) { diff --git a/src/fr/inrialpes/exmo/align/parser/XMLParser.java b/src/fr/inrialpes/exmo/align/parser/XMLParser.java index e4b42ed6..529040d5 100644 --- a/src/fr/inrialpes/exmo/align/parser/XMLParser.java +++ b/src/fr/inrialpes/exmo/align/parser/XMLParser.java @@ -303,7 +303,6 @@ public class XMLParser extends DefaultHandler { extensions = null; cl1 = null; cl2 = null; - // JE 2010: test that it works with SE [SEEMS TO WORK] } else if (pName.equals( SyntaxElement.MAP.name )) {//"map" try { alignment.init( onto1, onto2 ); -- GitLab