From 5e322e329e50b42c44b2e7ad57fcbc9e1b66c7a8 Mon Sep 17 00:00:00 2001
From: David Parsons <david.parsons@inria.fr>
Date: Fri, 15 Dec 2023 16:07:15 +0100
Subject: [PATCH] get rid of global variable for default value

---
 src/aevol_create.cpp | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/aevol_create.cpp b/src/aevol_create.cpp
index 57608904b..228c34b6c 100644
--- a/src/aevol_create.cpp
+++ b/src/aevol_create.cpp
@@ -42,8 +42,6 @@
 #include "parameters/ParamLoader.h"
 #include "parameters/ParamReader.h"
 
-const std::string DEFAULT_PARAM_FILE_NAME = "param.in";
-
 using namespace aevol;
 
 // Helper functions
@@ -123,7 +121,7 @@ void print_help(char* prog_path) {
 
 auto interpret_cmd_line_options(int argc, char* argv[]) -> std::tuple<std::string, std::string> {
   // Command-line option variables
-  std::string param_file_name;
+  std::string param_file_name = "param.in";
   std::string chromosome_file_name;
 
   // Define allowed options
@@ -165,11 +163,6 @@ auto interpret_cmd_line_options(int argc, char* argv[]) -> std::tuple<std::strin
     }
   }
 
-  // Set undefined command line parameters to default values
-  if (param_file_name.length() == 0) {
-    param_file_name = DEFAULT_PARAM_FILE_NAME;
-  }
-
   return std::make_tuple(param_file_name, chromosome_file_name);
 }
 
-- 
GitLab