From d7f88cd695ce1e045b6370ed15b4a9565ff8df36 Mon Sep 17 00:00:00 2001
From: Jad El karchi <elkarchie2@gmail.com>
Date: Sun, 23 Mar 2025 18:04:19 +0100
Subject: [PATCH] removed insertRows as it is unnecessary after successful
 createAndLoad, need to verbose and error handle

---
 R/push.R | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/R/push.R b/R/push.R
index 51330ce..dad5af0 100644
--- a/R/push.R
+++ b/R/push.R
@@ -22,7 +22,7 @@ upload_assay_data <- function(df, folder_path, target_name) {
 # Helper function to create dataset domain and upload data
 create_and_upload_dataset <- function(df, folder_path, schema_name, query_name) {
     message("Creating Domain : ", query_name)
-    labkey.domain.createAndLoad(
+    resp <- labkey.domain.createAndLoad(
         baseUrl = labkey.getBaseUrl(),
         domainKind = "StudyDatasetVisit",
         folderPath = folder_path,
@@ -31,17 +31,7 @@ create_and_upload_dataset <- function(df, folder_path, schema_name, query_name)
         df = df,
         description = ""
     )
-    message("Domain created.")
-
-    message("Uploading data ...")
-    labkey.importRows(
-        baseUrl = labkey.getBaseUrl(),
-        folderPath = folder_path,
-        schemaName = schema_name,
-        queryName = query_name,
-        toImport = df
-    )
-
+    message("Domain created and dataframe uploaded.")
     message(paste("Data uploaded to", folder_path, ", schema:", schema_name, ", query:", query_name))
 }
 
-- 
GitLab