* guix-kernel/jupyter-client.scm (<notebook>, notebook): Remove.
(json->notebook): Rename to...
(json->kernel): ... this, and adjust accordingly.
(read-message, send-message, relay-message, pub, pub-busy)
(pub-idle, reply-html): Adjust accordingly.
* guix-kernel/jupyter-server.scm (<kernel>)[key]: New field.
(kernel-iopub): New macro.
(kernel): Add #:key.
(close-kernel): New procedure.
* guix-jupyter-kernel.scm: Adjust, replacing "notebook" with "kernel".
* guix-jupyter-container.scm: Likewise.

Introduce <message> and <header> record that map directly to the Jupyter
specs.

This is a breaking change.

* guix-kernel-demo.ipynb: Update.

* environment.scm: Use (gnu packages guile-xyz) for 'guile-simple-zmq'.

* environment.scm (guile-simple-zmq): Remove.

* guix-jupyter-kernel.scm (send-to-container): Remove unused
'containers' parameter.
(proxy-exec-container, kill-containers): Adjust accordingly.

* guix-jupyter-kernel.scm: Use SRFI-19.
(session-id): Adjust accordingly.
(<proxy>): New record type.
(register-container, container-by-name, container-socket-by-name):
Remove.
(register-proxy, proxy-by-name): New procedures.
(reply-execute-request): Adjust accordingly.
(kill-containers): Rewrite using 'vlist-for-each'.
(new-container-connect): Return a proxy record.

* guix-kernel/jupyter-client.scm (pub, pub-busy, pub-idle): Remove
'socket' and 'key' parameters, add 'notebook' parameter instead.

* guix-jupyter-kernel.scm (%notebook): Remove.
(reply-kernel-info-request): Remove 'socket' parameter; add 'notebook'
parameter and adjust accordingly.
(reply-execute-request): Likewise.
(shutdown): Likewise.
(start-container): Add 'notebook' parameter and use it.
(start-kernel): Likewise.
(run-new-container): Remove.
<top level>: Adjust 'sigaction' and 'start-kernel' calls accordingly.

* guix-kernel/jupyter-client.scm (<notebook>): New record type.
(json->notebook, close-notebook): New procedures.
* guix-jupyter-kernel.scm (%notebook): New variable.
(notebook-info, get-notebook-info-atom)
(notebook-info-control-port, notebook-info-shell-port)
(notebook-info-transport, notebook-info-signature-scheme)
(notebook-info-stdin-port, notebook-info-heartbeat-port)
(notebook-info-ip, notebook-info-iopub-port)
(notebook-info-key, create-address, context)
(addr-heartbeat, addr-shell, addr-control, addr-iopub)
(addr-stdin, socket-heartbeat, socket-shell, socket-control)
(socket-iopub, socket-stdin, addresses, sockets): Remove.
Remove top-level calls to 'zmq-set-socket-option' and
'zmq-bind-socket'.
(proxy-exec-container, heartbeat-handler, general-handler)
(reply-kernel-info-request, reply-execute-request)
(start-container, start-kernel): Refer to %NOTEBOOK instead of referring
to the individual variables.
(atexit, sig-exit-handler): Remove.
(shutdown): Remove call to 'atexit'.
(exit-handler): New procedure.
Use it in top-level 'sigaction' calls.

* guix-kernel/jupyter-server.scm (<kernel>): New record type.
(kernel): New procedure.
(run-kernel): Return a <kernel> instead of an alist.
* guix-jupyter-container.scm (register-kernel): Replace 'name' and
'values' parameters with 'kernel'.
(kernel-by-name): Return the kernel itself, not the pair.
(kernel-shell-by-name, kernel-iosub-by-name): Remove.
(proxy-exec-kernel): Adjust accordingly.

* guix-kernel/jupyter-server.scm (new-connection-file): Change to use
keyword arguments.  Use 'call-with-output-file' instead of
'open-output-file'.
(run-kernel): Adjust accordingly.

This avoids the occasional string decoding error for byte streams that
were not actual UTF-8 strings.

This is based on commit fbab29d738b46d8637579ccec93be49520a4606f ("Fixed
a bug when the kernel could not send kernel_info (1 minute pause after
notebook starts)") of <https://github.com/jerry40/guile-kernel

>.

* guix-jupyter-container.scm (reply-execute-request): Turn UUID into a
bytevector.
* guix-jupyter-kernel.scm (send-to-container): Turn NAME into a
bytevector and use 'zmq-send-msg-parts-bytevector'.
(heartbeat-handler): Use '-bytevector' send and receive procedures.
(general-handler): Likewise.  Add calls to 'utf8->string' as needed.
* guix-kernel/jupyter-client.scm (send-to-jupyter)
(pub): Likewise.
* guix-kernel/jupyter-server.scm (run-kernel): Likewise.

Co-authored-by: jerry40 <epanfilov@gmail.com>

* guix-kernel/jupyter-server.scm (get-argv-from-file): Rename to...
(kernel-arguments): ... this; rewrite.
(exec-kernel): Simplify.

Fixes a regression introduced in
cd370ab1 whereby kernels other than
ipython would not be found because JUPYTER_PATH was unset.

* guix-kernel/jupyter-server.scm (jupyter-kernel-path): New procedure.
(find-kernel-by-name): Rewrite and search in (jupyter-kernel-path) by
default.
* guix-kernel/environ.scm (env-profile->str): Remove.
(make-new-environment): Set 'GUIX_PROFILE'.

* guix-kernel/jupyter-server.scm (get-argv-from-file): Use
'call-with-input-file' instead of 'open-file'.

* environment.scm: Use (current-source-location) instead of "." as the
basis of the current directory name.

* LICENSE: Rename to...
* COPYING: ... this.

* guix-kernel/environ.scm (make-new-environment): Remove hard-coded
search path variables and use 'profile-search-paths' instead.

Previously we assumed $PATH contained a single entry.

* guix-kernel/jupyter-server.scm (search-path->list): New procedure.
(exec-kernel): Use it along with 'search-path' to determine the absolute
file name of 'ipython'.

* environment.scm (guile-simple-zmq): New variable.

* environment.scm: Remove 'native-search-paths', which belongs in
'jupyter'.

* environment.scm: Pass #:select? to 'local-file'.

* Makefile.am (nobase_nodist_assets_DATA): Add kernel.json.
(EXTRA_DIST): Remove kernel.json.

* guix-kernel/hmac.scm (get-signature): Rewrite using (gcrypt hmac)
and (gcrypt base16).
* configure.ac: Check for (gcrypt hmac).
* environment.scm: Remove 'sed-openssl' phase; add GUILE-GCRYPT to DEPS
in the 'sed-kernel-json' phase.  Add GUILE-GCRYPT to 'propagated-inputs'.

* tests/hmac.scm ("unit: (get-signature empty string)"): Fix incorrect
expected value.
Fix typos.

* TODO.org: Update 'control socket' todo.

* guix-jupyter-kernel.scm (socket-shell): Set options ZMQ_RCVTIMEO to 50.
  (socket-control): Set options ZMQ_RCVTIMEO to 50.
* guix-jupyter-container.scm (shutdown): Modify 'quit' to 'exit'.

* guix-jupyter-kernel.scm (error->shtml, error->html): New procedures.
  (reply-execute-request): Catch 'guix-kernel' exception.
* guix-kernel/environ.scm (make-profile): Catch all exception and throw
  'guix-kernel' exception.

* guix-jupyter-kernel.scm: Get magic command 'html'.
* guix-jupyter-container.scm (reply-html-to-kernel): Add
  'guix-end-of-eval' message.
* guix-kernel/jupyter-client.scm (reply-html): Remove
  'guix-end-of-eval' message.

Ludovic Courtès authored Jul 17, 2018 and ROUBY Pierre-Antoine committed Jul 20, 2018

* guix-jupyter-container.scm (kernel-info->shtml): New procedure.
(kernel-info->html): Rewrite in terms of 'kernel-info->shtml'.
* guix-kernel/html.scm: Remove.
* Makefile.am (SOURCES): Adjust accordingly.

* TODO.org: remove IPython and environment (separator/html info).

* guix-jupyter-kernel.scm (general-handler): Simplify 'let' with
  'match'.
* guix-jupyter-container.scm (general-handler): Simplify 'let' with
  'match'.

Ludovic Courtès authored Jul 12, 2018 and ROUBY Pierre-Antoine committed Jul 17, 2018

* guix-jupyter-kernel.scm (%network-file-systems): New variable.
(start-container)[network-file-system]: Remove.
Use %NETWORK-FILE-SYSTEMS instead.

* README.org: Tested kernels add IPython.

* guix-kernel-demo.ipynb: Add Ipython.

* guix-jupyter-container.scm (proxy-exec-kernel): Get streams message
  type.
  (local-eval): Send 'guix-end-of-eval' message.
* guix-jupyter-kernel.scm (proxy-exec-container): Get streams message
  type.
* guix-kernel/jupyter-client.scm (reply-html): Send 'guix-end-of-eval'
  message.
* guix-kernel/jupyter-server.scm (exec-kernel): Add IPython.

* guix-jupyter-container.scm (kernel-info->html): Add warning at
  envrionment creation.
  (reply-execute-request): Update list ref.
* guix-jupyter-kernel.scm: Update list ref.
* guix-kernel/magic.scm (magic-env?): Test separator.
* tests/magic.scm (magic-no-code): Update string.
* README.org (How to use it): Update 'environment'.
* guix-kernel-demo.ipynb: Update with new syntax.

* guix-kernel/magic.scm (magic-html?): New procedure.
* guix-jupyter-container.scm (reply-html-to-kernel,
  kernel-info->html): New procedures.
* guix-jupyter-kernel.scm: Minor change.
* guix-kernel/html.scm: New file.
* guix-kernel/jupyter-client.scm (reply-html): New procedure.
* Makefile.am: Add 'guix-kernel/html.scm'.
* guix-kernel-demo.ipynb: Add example for new features.