Merge branch 'bugs/#13371' into 'master'

Fix request to kadeployapi when asking for a specific environment

See merge request !87

lib/grid5000/environments.rb

@@ -261,10 +261,15 @@ module Grid5000
     # environments. When user is anonymous, only list the public environments.
     def list(params = nil)
       kadeploy_params = {}
-      latest_only = (params && params.has_key?('latest_only')) ? params['latest_only'] : 'yes'
-      username = params['user'] if params && params.has_key?('user')
-      name = params['name'] if params && params.has_key?('name')
-      arch = params['arch'] if params && params.has_key?('arch')
+      latest_only = if params[:action] == 'show'
+                      'no'
+                    else
+                      params&.has_key?('latest_only') ? params['latest_only'] : 'yes'
+                    end
+
+      username = params['user'] if params&.has_key?('user')
+      name = params['name'] if params&.has_key?('name')
+      arch = params['arch'] if params&.has_key?('arch')
 
       kadeploy_params['last'] = true unless latest_only == 'no' || latest_only == 'false'
       kadeploy_params['username'] = username if username

spec/controllers/environments_controller_spec.rb

@@ -198,4 +198,34 @@ describe EnvironmentsController do
         'because you are seen as an anonymous one'
     end
   end
+
+  describe 'GET /environments/centos7-ppc64-min_2020120219_deploy' do
+    it 'should return one environment' do
+      authenticate_as('snoir')
+      stub_request(:get, @base_expected_uri).
+        with(
+          headers: {
+            'Accept' => 'application/json',
+            'Host' => 'api-out.local',
+            'X-Api-User-Cn' => 'snoir'
+          }).
+          to_return(status: 200, body: fixture('environments-grenoble.json'), headers: @headers_return)
+
+      stub_request(:get, @base_expected_uri + '?username=snoir').
+        with(
+          headers: {
+            'Accept' => 'application/json',
+            'Host' => 'api-out.local',
+            'X-Api-User-Cn' => 'snoir',
+          }).
+          to_return(status: 200, body: fixture('environments-grenoble-sno.json'), headers: @headers_return)
+
+      get :show, params: { site_id: 'grenoble', id: 'centos7-ppc64-min_2020120219_deploy', format: :json }
+
+      expect(response.status).to eq(200)
+      expect(json['links'].length).to eq(2)
+      expect(json['uid']).to eq('centos7-ppc64-min_2020120219_deploy')
+      expect(json.length).to eq(17)
+    end
+  end
 end