Comment and TODO item.

TODO

+* Clean up Lr1.incoming_symbol by going through Lr0.
+
 * Possibly re-implement the function [symbol] using a packed
   int array (going through [terminal] or [nonterminal] later).
+  Also, go through lr0 core first.
 
 * Generate default printers for terminal and nonterminal.
   Define printers for productions and items, parameterized

src/lr0.ml

@@ -142,7 +142,7 @@ let rec explore (symbol : Symbol.t option) (state : Item.Set.t) : node =
   (* Find out whether this state was already explored. *)
 
   try
-    Hashtbl.find map state in
+    Hashtbl.find map state
   with Not_found ->
 
     (* If not, create a new node. *)

src/lr1.ml

@@ -845,6 +845,12 @@ let conflicts f =
   ) conflict_nodes
 
 let incoming_symbol node =
+  (* Instead of reading [node.incoming_symbol], we could return
+     [Lr0.incoming_symbol (Lr0.core node.state)].
+     We could then get rid of the field [node.incoming_symbol].
+     However, this field is also used in the construction of the
+     table [incoming], so we would have to change the code that
+     builds this table. TEMPORARY do it! *)
   node.incoming_symbol
 
 let predecessors node =