GettingStartedWithModernCpp merge requestshttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests2021-04-24T10:27:27+02:00https://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/4Update readme to add documentation VSCode2021-04-24T10:27:27+02:00Vicente Mataix FerrándizUpdate readme to add documentation VSCodeThis adds additional documentation to the README. For example adds TOC and how to use Jupyter from VSCode. Also adds additional C++ referencesThis adds additional documentation to the README. For example adds TOC and how to use Jupyter from VSCode. Also adds additional C++ referencesVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/7Add a pre-commit git hook to prevent commit of a notebook with executed cells...2021-04-30T12:00:03+02:00GILLES SebastienAdd a pre-commit git hook to prevent commit of a notebook with executed cells withinClose #2Close #2GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/12[Docker] Adding Docker build2021-05-04T11:56:08+02:00Vicente Mataix Ferrándiz[Docker] Adding Docker buildThis adds a docker machine that avoids additional issuesThis adds a docker machine that avoids additional issuesVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/21Tackle both #8 and #13 about std::size_t2021-05-10T11:30:26+02:00GILLES SebastienTackle both #8 and #13 about std::size_t@steff and @vrouvrea (and of course @vicente.mataix if you wish but this MR follows remarks from Laurent and Vincent) if you can have a look at this very limited MR. Thanks!@steff and @vrouvrea (and of course @vicente.mataix if you wish but this MR follows remarks from Laurent and Vincent) if you can have a look at this very limited MR. Thanks!GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/24[STL] Comment about STL libraries performance2021-05-10T18:31:27+02:00Vicente Mataix Ferrándiz[STL] Comment about STL libraries performanceVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/26Typo found during template dry run2021-05-12T11:04:41+02:00ROUVREAU VincentTypo found during template dry run* Fix 'at bay'
* clarify where to find traits in cppreference
* type clarification
@steff @vicente.mataix your comments are welcome* Fix 'at bay'
* clarify where to find traits in cppreference
* type clarification
@steff @vicente.mataix your comments are welcomehttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/31Some typos and additionnal links2021-05-21T09:04:34+02:00ROUVREAU VincentSome typos and additionnal linkshttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/33Replace TP by HandsOn2021-05-25T14:39:26+02:00GILLES SebastienReplace TP by HandsOnAs prescribed by #20.As prescribed by #20.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/38The 2 sentences were saying the same thing about ptrdiff2022-09-21T09:37:28+02:00ROUVREAU VincentThe 2 sentences were saying the same thing about ptrdiffI kept the last written one on e8ead53a
Fix #28I kept the last written one on e8ead53a
Fix #28ROUVREAU VincentROUVREAU Vincenthttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/39An example of constructor call with braces - empty braces to fix the most vex...2022-09-21T09:39:37+02:00ROUVREAU VincentAn example of constructor call with braces - empty braces to fix the most vexing parse problemFix #31Fix #31ROUVREAU VincentROUVREAU Vincenthttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/40Make Binder work again (at least for C++ 17 kernel)2022-09-26T14:14:11+02:00GILLES SebastienMake Binder work again (at least for C++ 17 kernel)The Binder as defined in May 2021 no longer worked (due to an issue from Xeus-cling - their demo Binder no longer works as well).
But modifying it with the compiler hint provided by Nicolas Thierry works: https://github.com/jupyter-xeus...The Binder as defined in May 2021 no longer worked (due to an issue from Xeus-cling - their demo Binder no longer works as well).
But modifying it with the compiler hint provided by Nicolas Thierry works: https://github.com/jupyter-xeus/xeus-cling/issues/413
I also moved the environment.yml file into a directory which makes its use more obvious, following suggestion from repo2docker documentation.
Solves #38GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/42Rework operator list and precedence. Modify example on conversion operator2022-09-29T09:12:17+02:00ROUVREAU VincentRework operator list and precedence. Modify example on conversion operatorFix #34Fix #34ROUVREAU VincentROUVREAU Vincenthttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/41Minor modifications in CI and notebooks2022-10-03T10:11:06+02:00GILLES SebastienMinor modifications in CI and notebooks- Update the README.md to reflect 2022 situation.
- /close #36 Update copyright year.
- #35 Rename the Dockerfiles, and make the gitlab-ci.yml file more DRY with the use of (Yaml) template.
- Docker: put myself as maintainer as Vicente n...- Update the README.md to reflect 2022 situation.
- /close #36 Update copyright year.
- #35 Rename the Dockerfiles, and make the gitlab-ci.yml file more DRY with the use of (Yaml) template.
- Docker: put myself as maintainer as Vicente no longer works for Inria.
- /close #25 Rename the Conda environment.
@steff You may review as well; I'm waiting for an approval to merge it :wink:GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/43Modifications done while reading again the formation2022-10-03T14:16:37+02:00GILLES SebastienModifications done while reading again the formation- Most changes are fairly minor, including /close #32
- In Functions notebook, a more detailed explanation about declaration and definition has been added.
- Update some data to reflect 2022 standpoint
- Add Coliru links when stuff that...- Most changes are fairly minor, including /close #32
- In Functions notebook, a more detailed explanation about declaration and definition has been added.
- Update some data to reflect 2022 standpoint
- Add Coliru links when stuff that worked in 2021 is broken in Xeus-Cling circa 2022
I hope I haven't broken anything - I made the first version of a branch following !35 and had to backport my modifications in the more senseful hierarchy used in main branch (I will take a Linux laptop for my rereading / modifications of the hands ons).
@vrouvrea @steff As usual any reviewer would do :wink:GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/44Fix handson code convention2022-10-03T16:51:22+02:00ROUVREAU VincentFix handson code convention* Fix #32 using clang-tidy and clang-format (cf. config files added in `HandsOn/Config`)
* Try to forgot nothing in instructions notebooks
* Fix cmake issue on solution of exercice43 (missing `project()`)
To be discussed:
* I renamed va...* Fix #32 using clang-tidy and clang-format (cf. config files added in `HandsOn/Config`)
* Try to forgot nothing in instructions notebooks
* Fix cmake issue on solution of exercice43 (missing `project()`)
To be discussed:
* I renamed variable `Nbits` as `nbits`
* I renamed `display_065_3515_035_4832` as `Display065_3515_035_4832`ROUVREAU VincentROUVREAU Vincenthttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/46HandOn: rename DisplayMultiply() DisplaySumOfMultiply()2022-10-04T11:05:30+02:00GILLES SebastienHandOn: rename DisplayMultiply() DisplaySumOfMultiply()@steff @vrouvrea
I've just begun to read the hands on (still in procedural...) but one of the modifications I have made is impactful for most hands on so I deemed it better to share it immediately.
There is a function which was called...@steff @vrouvrea
I've just begun to read the hands on (still in procedural...) but one of the modifications I have made is impactful for most hands on so I deemed it better to share it immediately.
There is a function which was called `display_sum()` which I renamed `display_multiply()`... which is not really better. I have renamed it `DisplaySumOfMultiply(`, which albeit ugly is correct. The notebook has been corrected as well (a `display_sum` slipped through and was unduly kept).
Others modifications are much more minor:
- I heeded a warning from CMake and changed the type of the variable which indicated which C++ standard was used.
- A typo was corrected.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/47codespell on notebooks only2022-10-04T13:47:34+02:00ROUVREAU Vincentcodespell on notebooks onlyFix #39
Modifications:
```
./4-Templates/4-Metaprogramming.ipynb:17: heterogenous ==> heterogeneous
./4-Templates/4-Metaprogramming.ipynb:17: objets ==> objects
./4-Templates/4-Metaprogramming.ipynb:30: recommand ==> recommend
./4-Templ...Fix #39
Modifications:
```
./4-Templates/4-Metaprogramming.ipynb:17: heterogenous ==> heterogeneous
./4-Templates/4-Metaprogramming.ipynb:17: objets ==> objects
./4-Templates/4-Metaprogramming.ipynb:30: recommand ==> recommend
./4-Templates/4-Metaprogramming.ipynb:33: heterogenous ==> heterogeneous
./4-Templates/4-Metaprogramming.ipynb:33: objets ==> objects
./4-Templates/3-Syntax.ipynb:272: fo ==> to
./4-Templates/5-MoreAdvanced.ipynb:225: informations ==> information
./3-Operators/2-Comparison.ipynb:102: independant ==> independent
./3-Operators/4-CanonicalForm.ipynb:460: typicall ==> typical
./HandsOn/HowTo.ipynb:66: allright ==> alright
./HandsOn/HowTo.ipynb:98: informations ==> information
./1-ProceduralProgramming/3-Types.ipynb:951: informations ==> information
./1-ProceduralProgramming/3-Types.ipynb:980: litterals ==> literals
./1-ProceduralProgramming/3-Types.ipynb:982: litterals ==> literals
./1-ProceduralProgramming/3-Types.ipynb:1005: litterals ==> literals
./1-ProceduralProgramming/4-Functions.ipynb:119: direcly ==> directly
./1-ProceduralProgramming/4-Functions.ipynb:331: euclidian ==> euclidean
./1-ProceduralProgramming/4-Functions.ipynb:352: Euclidian ==> Euclidean
./1-ProceduralProgramming/4b-hands-on.ipynb:233: thefore ==> therefore
./1-ProceduralProgramming/5-DynamicAllocation.ipynb:30: independant ==> independent
./1-ProceduralProgramming/5-DynamicAllocation.ipynb:110: automatize ==> automate
./7-Appendix/HomemadeException.ipynb:184: withou ==> without
./7-Appendix/StringView.ipynb:124: responsability ==> responsibility
./7-Appendix/Crtp.ipynb:17: Refering ==> Referring
./7-Appendix/Crtp.ipynb:543: Refering ==> Referring
./7-Appendix/WeakPtr.ipynb:402: consistant ==> consistent
./7-Appendix/WeakPtr.ipynb:637: occured ==> occurred
./7-Appendix/WeakPtr.ipynb:684: dependancies ==> dependencies
./5-UsefulConceptsAndSTL/4-AssociativeContainers.ipynb:411: independant ==> independent
./5-UsefulConceptsAndSTL/5-MoveSemantics.ipynb:859: assigmnent ==> assignment
./5-UsefulConceptsAndSTL/3-Containers.ipynb:171: independantly ==> independently
./5-UsefulConceptsAndSTL/1b-hands-on.ipynb:51: equiped ==> equipped
./5-UsefulConceptsAndSTL/1b-hands-on.ipynb:130: atribute ==> attribute
./5-UsefulConceptsAndSTL/2-RAII.ipynb:34: Ressource ==> Resource
./5-UsefulConceptsAndSTL/2-RAII.ipynb:35: ressources ==> resources
./5-UsefulConceptsAndSTL/2-RAII.ipynb:82: ressources ==> resources
./5-UsefulConceptsAndSTL/2-RAII.ipynb:97: ressources ==> resources
./5-UsefulConceptsAndSTL/2-RAII.ipynb:130: ressource ==> resource
./5-UsefulConceptsAndSTL/6-SmartPointers.ipynb:50: responsability ==> responsibility
./5-UsefulConceptsAndSTL/6-SmartPointers.ipynb:89: ressources ==> resources
./5-UsefulConceptsAndSTL/6-SmartPointers.ipynb:265: ressource ==> resource
./5-UsefulConceptsAndSTL/6-SmartPointers.ipynb:377: dependancy ==> dependency
./2-ObjectProgramming/2-Member-functions.ipynb:87: atttributes ==> attributes
./2-ObjectProgramming/7-polymorphism.ipynb:429: overriden ==> overridden
./2-ObjectProgramming/7-polymorphism.ipynb:617: Overriden ==> Overridden
./2-ObjectProgramming/5-static.ipynb:103: atribute ==> attribute
./2-ObjectProgramming/4b-hands-on.ipynb:42: accomodate ==> accommodate
./2-ObjectProgramming/4-encapsulation.ipynb:172: langage ==> language
./bibliography.ipynb:28: brillant ==> brilliant
./bibliography.ipynb:82: independant ==> independent
./bibliography.ipynb:90: developement ==> development
./6-InRealEnvironment/4-ThirdParty.ipynb:47: purposedly ==> purposely
./6-InRealEnvironment/5-Namespace.ipynb:36: preffixed ==> prefixed
./6-InRealEnvironment/5-Namespace.ipynb:305: preffix ==> prefix
./6-InRealEnvironment/5-Namespace.ipynb:453: preffix ==> prefix
./6-InRealEnvironment/5-Namespace.ipynb:471: preffix ==> prefix
./6-InRealEnvironment/3-Compilers.ipynb:39: softwares ==> software
./6-InRealEnvironment/3-Compilers.ipynb:87: intentionaly ==> intentionally
./6-InRealEnvironment/6-Tools.ipynb:71: informations ==> information
./6-InRealEnvironment/2-FileStructure.ipynb:248: attemps ==> attempts
./6-InRealEnvironment/2-FileStructure.ipynb:899: preferrably ==> preferably
```
Proposed modifications I was not agree with:
```
./2-ObjectProgramming/2-Member-functions.ipynb:409: Tread ==> Thread, treat - I did not know this expression "Tread with caution"
./4-Templates/5-MoreAdvanced.ipynb:450: seemlessly ==> seamlessly
./5-UsefulConceptsAndSTL/5-MoveSemantics.ipynb:267: seemlessly ==> seamlessly
```ROUVREAU VincentROUVREAU Vincenthttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/36Update pre-commit git hook and its documentation to clear executed cells from...2022-10-04T16:13:30+02:00ROUVREAU VincentUpdate pre-commit git hook and its documentation to clear executed cells from notebooksThis MR fixes #4This MR fixes #4ROUVREAU VincentROUVREAU Vincenthttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/51#14 Function notebook: remove Xeus cling introspection and add instead links2022-10-04T16:57:52+02:00GILLES Sebastien#14 Function notebook: remove Xeus cling introspection and add instead links/closes #14/closes #14GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/49Remove an ambiguous sentence2022-10-04T17:01:23+02:00GILLES SebastienRemove an ambiguous sentenceGILLES SebastienGILLES Sebastien