GettingStartedWithModernCpp merge requestshttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests2021-05-17T09:50:07+02:00https://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/28#19 Add in CI the creation of the other images2021-05-17T09:50:07+02:00GILLES Sebastien#19 Add in CI the creation of the other images- Move the content of Config in the `docker` directory.
- Add in CI a step to generate the Fedora image for TP.
- In the main README, add a brief explanation about the Docker command.
- In TP, reduce the README as the relevant informatio...- Move the content of Config in the `docker` directory.
- Add in CI a step to generate the Fedora image for TP.
- In the main README, add a brief explanation about the Docker command.
- In TP, reduce the README as the relevant informations is now given elsewhere.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/30Add a paragraph about smart pointers efficiency, citing the reference given i...2022-09-16T17:23:09+02:00GILLES SebastienAdd a paragraph about smart pointers efficiency, citing the reference given in MR29.As proposed in !29, add a paragraph about overhead in memory and performance for smart pointers, which is not paraphrasing the cited article.As proposed in !29, add a paragraph about overhead in memory and performance for smart pointers, which is not paraphrasing the cited article.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/103Add a small section for inf or nan.2024-03-18T11:33:34+01:00GILLES SebastienAdd a small section for inf or nan.Closes #129Closes #129GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/18Add in appendix a notebook explaining briefly std::string_view2021-05-10T07:04:21+02:00GILLES SebastienAdd in appendix a notebook explaining briefly std::string_viewAlso add in types the initialization of `std::string` from string litterals.
As usual any feedback from any of you @steff, @vrouvrea or @vicente.mataix is welcome!Also add in types the initialization of `std::string` from string litterals.
As usual any feedback from any of you @steff, @vrouvrea or @vicente.mataix is welcome!GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/5Adding doctest to the documentation2021-03-23T14:59:41+01:00Vicente Mataix FerrándizAdding doctest to the documentationBasically that (I like a lot the library, is the fastest!)Basically that (I like a lot the library, is the fastest!)Vicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/11Create a new notebook in procedural to discuss static and constexpr2021-05-07T17:46:14+02:00GILLES SebastienCreate a new notebook in procedural to discuss static and constexprCreate a new notebook in procedural to discuss static and constexpr. The static part was lifted from the notebook in object programming in which it was originally introduced.
As always I chose one of you as reviewer but I would gladly t...Create a new notebook in procedural to discuss static and constexpr. The static part was lifted from the notebook in object programming in which it was originally introduced.
As always I chose one of you as reviewer but I would gladly take feedback from @vrouvrea as well :wink:GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/8[DOC] Replace notebook with lab2021-05-04T11:54:36+02:00Vicente Mataix Ferrándiz[DOC] Replace notebook with labI think it can be interesting as it simplifies the workflow:
![image](/uploads/edec7147521c18370f9fd1f6c40e7fae/image.png)
For example you can see in different tabs the TP and the theoryI think it can be interesting as it simplifies the workflow:
![image](/uploads/edec7147521c18370f9fd1f6c40e7fae/image.png)
For example you can see in different tabs the TP and the theoryVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/16[Documentation] Minor changes2021-05-05T14:29:22+02:00Vicente Mataix Ferrándiz[Documentation] Minor changesAdding some additional minor , this was part of !14Adding some additional minor , this was part of !14Vicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/13[DO NOT MERGE] Tutor lottery for the notebooks2021-05-04T18:04:11+02:00Vicente Mataix Ferrándiz[DO NOT MERGE] Tutor lottery for the notebooks@steff @sgilles @vrouvrea
This MR performs a CI with a lottery of the notebooks for each one. We can run it as much times as you want, as it is random the idea is to do it just once@steff @sgilles @vrouvrea
This MR performs a CI with a lottery of the notebooks for each one. We can run it as much times as you want, as it is random the idea is to do it just onceVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/6Draft: Resolve "Add a pre-commit git hook to prevent commit of a notebook wit...2021-04-24T11:21:13+02:00GILLES SebastienDraft: Resolve "Add a pre-commit git hook to prevent commit of a notebook with executed cells within"Closes #2Closes #2GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/75Few corrections and updates in the introductory notebooks2024-03-01T19:22:56+01:00GILLES SebastienFew corrections and updates in the introductory notebooks@vrouvrea In the very first notebook it is said Gudhi still uses up C++ 14; I think that's no longer the case.
If I'm right, can you update the standard and the date of the upgrade? Thanks!@vrouvrea In the very first notebook it is said Gudhi still uses up C++ 14; I think that's no longer the case.
If I'm right, can you update the standard and the date of the upgrade? Thanks!GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/65Fix Binder instance run2024-02-15T11:11:37+01:00GILLES SebastienFix Binder instance runIn MR !62; I broke the generation of Binder instance, as strangely enough the Conda environment that works on Linux and for Docker images utterly fail in Binder (and the version that works for Binder fails locally and for Linux images......In MR !62; I broke the generation of Binder instance, as strangely enough the Conda environment that works on Linux and for Docker images utterly fail in Binder (and the version that works for Binder fails locally and for Linux images... :thinking: )
Here I fix this, albeit not in the prettiest possible way (basically I provide two different Yaml environments: one for local/Docker and another for Binder.
I have updated the README to reflect both changes.
**Note:** I have in fact locally worked on top of the branch provided in !62 and have cherry-picked the commits to put them on top of current `master` branch.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/32Fix following training session from the 20th of May 20212021-06-02T09:50:24+02:00GILLES SebastienFix following training session from the 20th of May 2021Issues #21 and #22 are tackled in this MR.Issues #21 and #22 are tackled in this MR.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/72Fix three issues related to hands on2024-02-27T15:04:22+01:00GILLES SebastienFix three issues related to hands onCloses #68, #69, #99Closes #68, #69, #99GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/1fix: typos2021-03-23T14:59:23+01:00STEFF Laurentfix: typoshttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/95Hands on how to: add a section about pros and cons on separating or not decla...2024-03-14T09:12:43+01:00GILLES SebastienHands on how to: add a section about pros and cons on separating or not declarations and definitionsGILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/27Make the creation of Docker images a specific process to ask in Gitlab interface2021-05-14T12:06:15+02:00GILLES SebastienMake the creation of Docker images a specific process to ask in Gitlab interfaceThis MR aims to address #16 .
As usual @steff and @vicente.mataix your input is welcome!This MR aims to address #16 .
As usual @steff and @vicente.mataix your input is welcome!GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/14[Notebooks] Adding some example of direct compilation in the Notebooks in 6-I...2021-05-05T09:48:14+02:00Vicente Mataix Ferrándiz[Notebooks] Adding some example of direct compilation in the Notebooks in 6-InRealEnvironmentUsing ! to direct execute the compilation without needing to open a terminal
(This avoids breaking the workflow of the class)
Also adding some additional doc (it can be separated in a different MR, so doesn't mesh with the previous one)Using ! to direct execute the compilation without needing to open a terminal
(This avoids breaking the workflow of the class)
Also adding some additional doc (it can be separated in a different MR, so doesn't mesh with the previous one)Vicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/9Overhaul of the formation2021-05-03T17:44:30+02:00GILLES SebastienOverhaul of the formationEssentially:
- All notebooks have been read and more or less amended.
- The notebook about inheritance has been heavily amended.
- Some passing remarks on C++ 20 have been added here and there.
- The copyright year has been updated.
Wh...Essentially:
- All notebooks have been read and more or less amended.
- The notebook about inheritance has been heavily amended.
- Some passing remarks on C++ 20 have been added here and there.
- The copyright year has been updated.
What has NOT been reviewed this time are the TPs (except regarding the copyright years).
One of the reviewers (@steff or @vrouvrea) should also handle [this (very quick) issue](https://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/issues/3)GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/35Overhaul of the set up required to be able to run the formation2022-10-13T23:12:16+02:00GILLES SebastienOverhaul of the set up required to be able to run the formation@steff @vrouvrea
This merge request deals with #25, #36 and #35.
By far most of the modifications are from #35, and to be honest some of them are not clean enough, but I really needed to have a functional set up to be able to review a...@steff @vrouvrea
This merge request deals with #25, #36 and #35.
By far most of the modifications are from #35, and to be honest some of them are not clean enough, but I really needed to have a functional set up to be able to review and edit the notebooks (the main issue with Podman was to ensure that modifications done on the notebook in the browser may be saved correctly in the notebook file on the host).
Tbh, I wonder if we shouldn't move away from Jupyter notebooks in the future and use a Web-based solution (as the "Run this code" in https://en.cppreference.com). But this is a discussion for another time :wink:
Due to the modifications I had to do, I would like both your approval before merging it. Thanks!GILLES SebastienGILLES Sebastien