GettingStartedWithModernCpp merge requestshttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests2021-05-10T11:29:07+02:00https://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/22[Types] Adding mention to std::ptrdiff_t, signed counter part of std::size_t2021-05-10T11:29:07+02:00Vicente Mataix Ferrándiz[Types] Adding mention to std::ptrdiff_t, signed counter part of std::size_tSorry I saw !21 to late. I think it is relevant to mention it's signed counterpartSorry I saw !21 to late. I think it is relevant to mention it's signed counterpartVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/20Polymorphism notebook2021-05-10T10:58:48+02:00GILLES SebastienPolymorphism notebookThe idea is to split inheritance and polymorphism: the notebook with both was rather heavy...
It's easier now to possibly not tackle both the same day.
TP has not been retought (the numbering has been modified so that TP occurs after p...The idea is to split inheritance and polymorphism: the notebook with both was rather heavy...
It's easier now to possibly not tackle both the same day.
TP has not been retought (the numbering has been modified so that TP occurs after polymorphism has been studied...) but for the next time we will do TP it could be ice to split so that there are exercices just after inheritance notebook.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/19Some typos, init with braces and explanation for semicolon at the end of struct2021-05-10T10:41:46+02:00ROUVREAU VincentSome typos, init with braces and explanation for semicolon at the end of struct* Most of the modifications are typos.
* In classes, I use braces to initialize a default attribute value right after it is explained to do so (instead of =)
* I changed 2 links that were mentioning parshift, but the links were to isocpp...* Most of the modifications are typos.
* In classes, I use braces to initialize a default attribute value right after it is explained to do so (instead of =)
* I changed 2 links that were mentioning parshift, but the links were to isocpp.
* I added a paragraph to explain why we put a semicolon at the end of a struct and class (maybe because I see this error too often with ENSTA students)
* I added a note about prefixing an attribute with an underscore that is reserved to the standard
* Some code cells were in markdownhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/18Add in appendix a notebook explaining briefly std::string_view2021-05-10T07:04:21+02:00GILLES SebastienAdd in appendix a notebook explaining briefly std::string_viewAlso add in types the initialization of `std::string` from string litterals.
As usual any feedback from any of you @steff, @vrouvrea or @vicente.mataix is welcome!Also add in types the initialization of `std::string` from string litterals.
As usual any feedback from any of you @steff, @vrouvrea or @vicente.mataix is welcome!GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/17typo found during procedural dry run2021-05-05T13:43:57+02:00ROUVREAU Vincenttypo found during procedural dry runhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/16[Documentation] Minor changes2021-05-05T14:29:22+02:00Vicente Mataix Ferrándiz[Documentation] Minor changesAdding some additional minor , this was part of !14Adding some additional minor , this was part of !14Vicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/15Rewrite partly the Dockerfile2021-05-07T19:00:34+02:00GILLES SebastienRewrite partly the DockerfileSo that:
- The image is derived from continuumio/miniconda3 rather than Ubuntu (maybe it is not the right call - no clue one way or another, but we probably have shave off a bit of space. The miniconda one is apparently base on Debian)....So that:
- The image is derived from continuumio/miniconda3 rather than Ubuntu (maybe it is not the right call - no clue one way or another, but we probably have shave off a bit of space. The miniconda one is apparently base on Debian).
- The project is no longer cloned from gitlab, but is rather read from the host (the command line is therefore a bit longer and is documented in the README). The reason for doing so is that the image is lighter and fork may build their own image from their actual master branch rather than silently taking the one from the main project.
I have also removed several lines that seems to add nothing; maybe I was wrong on some of these calls.
The terminal where the `run` command is run is no longer silent; I don't know what triggered the difference here.
I assigned the issue to @vicente.mataix as he was the author of the first draft of the Dockerfile, but I would as usual gladly take input from you @vrouvrea and @steff.GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/14[Notebooks] Adding some example of direct compilation in the Notebooks in 6-I...2021-05-05T09:48:14+02:00Vicente Mataix Ferrándiz[Notebooks] Adding some example of direct compilation in the Notebooks in 6-InRealEnvironmentUsing ! to direct execute the compilation without needing to open a terminal
(This avoids breaking the workflow of the class)
Also adding some additional doc (it can be separated in a different MR, so doesn't mesh with the previous one)Using ! to direct execute the compilation without needing to open a terminal
(This avoids breaking the workflow of the class)
Also adding some additional doc (it can be separated in a different MR, so doesn't mesh with the previous one)Vicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/13[DO NOT MERGE] Tutor lottery for the notebooks2021-05-04T18:04:11+02:00Vicente Mataix Ferrándiz[DO NOT MERGE] Tutor lottery for the notebooks@steff @sgilles @vrouvrea
This MR performs a CI with a lottery of the notebooks for each one. We can run it as much times as you want, as it is random the idea is to do it just once@steff @sgilles @vrouvrea
This MR performs a CI with a lottery of the notebooks for each one. We can run it as much times as you want, as it is random the idea is to do it just onceVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/11Create a new notebook in procedural to discuss static and constexpr2021-05-07T17:46:14+02:00GILLES SebastienCreate a new notebook in procedural to discuss static and constexprCreate a new notebook in procedural to discuss static and constexpr. The static part was lifted from the notebook in object programming in which it was originally introduced.
As always I chose one of you as reviewer but I would gladly t...Create a new notebook in procedural to discuss static and constexpr. The static part was lifted from the notebook in object programming in which it was originally introduced.
As always I chose one of you as reviewer but I would gladly take feedback from @vrouvrea as well :wink:GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/10Update google test doc2021-05-03T17:50:39+02:00STEFF LaurentUpdate google test dochttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/9Overhaul of the formation2021-05-03T17:44:30+02:00GILLES SebastienOverhaul of the formationEssentially:
- All notebooks have been read and more or less amended.
- The notebook about inheritance has been heavily amended.
- Some passing remarks on C++ 20 have been added here and there.
- The copyright year has been updated.
Wh...Essentially:
- All notebooks have been read and more or less amended.
- The notebook about inheritance has been heavily amended.
- Some passing remarks on C++ 20 have been added here and there.
- The copyright year has been updated.
What has NOT been reviewed this time are the TPs (except regarding the copyright years).
One of the reviewers (@steff or @vrouvrea) should also handle [this (very quick) issue](https://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/issues/3)GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/8[DOC] Replace notebook with lab2021-05-04T11:54:36+02:00Vicente Mataix Ferrándiz[DOC] Replace notebook with labI think it can be interesting as it simplifies the workflow:
![image](/uploads/edec7147521c18370f9fd1f6c40e7fae/image.png)
For example you can see in different tabs the TP and the theoryI think it can be interesting as it simplifies the workflow:
![image](/uploads/edec7147521c18370f9fd1f6c40e7fae/image.png)
For example you can see in different tabs the TP and the theoryVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/6Draft: Resolve "Add a pre-commit git hook to prevent commit of a notebook wit...2021-04-24T11:21:13+02:00GILLES SebastienDraft: Resolve "Add a pre-commit git hook to prevent commit of a notebook with executed cells within"Closes #2Closes #2GILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/5Adding doctest to the documentation2021-03-23T14:59:41+01:00Vicente Mataix FerrándizAdding doctest to the documentationBasically that (I like a lot the library, is the fastest!)Basically that (I like a lot the library, is the fastest!)Vicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/3Update gitignore2021-03-23T11:40:25+01:00Vicente Mataix FerrándizUpdate gitignoreBasically that.
I am testing the notebooks with VSCode and it woul be interesting to remove vscode from the git detectionBasically that.
I am testing the notebooks with VSCode and it woul be interesting to remove vscode from the git detectionVicente Mataix FerrándizVicente Mataix Ferrándizhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/2[README.md] Adding my binder.org link2021-05-03T18:22:04+02:00Vicente Mataix Ferrándiz[README.md] Adding my binder.org linkGILLES SebastienGILLES Sebastienhttps://gitlab.inria.fr/formations/cpp/gettingstartedwithmoderncpp/-/merge_requests/1fix: typos2021-03-23T14:59:23+01:00STEFF Laurentfix: typos