Mentions légales du service

Skip to content

Bugfix for gnomon issue number 254: the main window size can not be decreased vertically.

LACROIX Romain requested to merge feature/bug-menubar-height into develop

The call to dtkWidgetsMenuBar::setFixedHeight() is done by dtkWidgetsMainWindow::resizeEvent().

It is thus not a fixed height we should set, but a normal not-fixed height / size.

Fixes gnomon issue 254

Tested working against gnomon and against example dtkWidgetsMenu.

2 questions for the reviewer :

  1. Should we rename dtkWidgetsMenuBar::setFixedHeight() to setHeight() because the name is now not correct? Would this rename cause many incompatibilities because other classes and other research software need to be updated?
  2. Should we apply the patch "change setFixedHeight() call to resize() call" only to the QFrame parent class, not to the d->c dtkWidgetsMenuBarContainer member because it is not required to fix the issue?
Edited by LACROIX Romain

Merge request reports