Skip to content

GitLab

Attention une mise à jour du service Gitlab va être effectuée le mardi 14 décembre entre 13h30 et 14h00. Cette mise à jour va générer une interruption du service dont nous ne maîtrisons pas complètement la durée mais qui ne devrait pas excéder quelques minutes.

Closed
Created by LACROIX Romain@rlacroixContributor

Multiple menu bars is not correctly supported

To support multiple menu bars, the variable QList<dtkWidgetsMenu *> stack must be a member of the MenuBar class, it can not be a static / global variable shared between all menu bars, otherwise this crash will happen:

With Gnomon at commit 7d1dc20470f5a33c281529ae63b2bdf9b7589428 or later (either in branch feature/menu-improvements or in branch develop if merged), do these actions

[1] In the PlantGL panel, expand the sub-menu File/Open of the menu bar

[2] In the Code panel, click on the file icon to expand its menu, then click the file icon again to collapse its menu

It crashes here because the shared stack variable is empty but it is expected to not be empty.

We propose the following fix: have the stack variable be a member of the MenuBar class.

Edited by LACROIX Romain
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information