croco issueshttps://gitlab.inria.fr/croco-ocean/croco/-/issues2022-09-27T16:44:40+02:00https://gitlab.inria.fr/croco-ocean/croco/-/issues/2RK3 stable2022-09-27T16:44:40+02:00Rachid BenshilaRK3 stableDEBREU LaurentDEBREU Laurent2017-07-13https://gitlab.inria.fr/croco-ocean/croco/-/issues/13debug2022-03-31T19:02:37+02:00DEBREU LaurentdebugGeneralize debug to compare 2 parallel runs (or 2 sequential runs)Generalize debug to compare 2 parallel runs (or 2 sequential runs)DEBREU LaurentDEBREU Laurent2019-03-11https://gitlab.inria.fr/croco-ocean/croco/-/issues/14bug at compilation with options AGRIF+WET_DRY+FRC_BRY2022-03-31T19:02:37+02:00Laurent ROBLOUbug at compilation with options AGRIF+WET_DRY+FRC_BRYThere is a missing piece of code to handle boundary conditions at compilation for the case AGRIF+WET_DRY+FRC_BRY (code compilation fails and complains about variables ubclm, vbclm).There is a missing piece of code to handle boundary conditions at compilation for the case AGRIF+WET_DRY+FRC_BRY (code compilation fails and complains about variables ubclm, vbclm).Bug fixLaurent ROBLOULaurent ROBLOU2019-03-13https://gitlab.inria.fr/croco-ocean/croco/-/issues/15bad termination after blow up with NBQ+AGRIF options2022-03-31T19:02:37+02:00Laurent ROBLOUbad termination after blow up with NBQ+AGRIF optionsAfter STEP3D_FAST blow up (run with NBQ+AGRIF options), the run is not properly terminated by croco binary, leading to a (massive) loss of computing hours.After STEP3D_FAST blow up (run with NBQ+AGRIF options), the run is not properly terminated by croco binary, leading to a (massive) loss of computing hours.Bug fixCyril NguyenCyril Nguyen2019-03-15https://gitlab.inria.fr/croco-ocean/croco/-/issues/36bug in sed_mustang_skinstress2022-01-18T10:47:27+01:00Matthieu Caillaudbug in sed_mustang_skinstressWrong time index were used to compute skin stress from U,V
To correct the bug **nrsh** has been replaced by **nnew**
Bug has been fixed in this commit :
be26438d56d684b0056d685cd81e5294e3df6041Wrong time index were used to compute skin stress from U,V
To correct the bug **nrsh** has been replaced by **nnew**
Bug has been fixed in this commit :
be26438d56d684b0056d685cd81e5294e3df6041MustangMatthieu CaillaudMatthieu Caillaud2022-01-19https://gitlab.inria.fr/croco-ocean/croco/-/issues/37Negative sand concentration2022-02-11T12:30:03+01:00Solene Le GacNegative sand concentrationIn t3dmix_tridiagonal_settling.h, when the number of substep is defined, a function NINT is used.
This choice could lead to unstable concentration of sand .
A fix could be to use the function CEILING instead of NINT
in https://gitlab.in...In t3dmix_tridiagonal_settling.h, when the number of substep is defined, a function NINT is used.
This choice could lead to unstable concentration of sand .
A fix could be to use the function CEILING instead of NINT
in https://gitlab.inria.fr/croco-ocean/croco/-/blob/dev_2022_mustang/MUSTANG/t3dmix_tridiagonal_settling.h#L126
Exemple to test :
1DV case without current, only settling of sediment.
Use the attached file to compile and run (.pbs for datarmor, env variable $croco to adjust )
If you plot the vertical profile of sand concentration at time step number 20 you will see the instability like on the image![sand](/uploads/1957663f43d4751e018abfc8bc6cd711/sand.gif)
[V2morpho_ref.zip](/uploads/f62932e45642217c5220d76ac7fe9300/V2morpho_ref.zip)MustangSolene Le GacSolene Le Gac2022-01-28https://gitlab.inria.fr/croco-ocean/croco/-/issues/30Sediment Pick-up function - Van Rijn, 19842022-09-08T10:51:37+02:00Solene Le GacSediment Pick-up function - Van Rijn, 1984In https://gitlab.inria.fr/croco-ocean/croco/-/blob/dev_2022_mustang/MUSTANG/sed_MUSTANG.F90#L3800
0,000005 should be 0,00033 according to Van Rijn pick-up function (https://www.leovanrijn-sediment.com/papers/P2-1984c.pdf page 4)In https://gitlab.inria.fr/croco-ocean/croco/-/blob/dev_2022_mustang/MUSTANG/sed_MUSTANG.F90#L3800
0,000005 should be 0,00033 according to Van Rijn pick-up function (https://www.leovanrijn-sediment.com/papers/P2-1984c.pdf page 4)MustangSolene Le GacSolene Le Gac2022-02-01https://gitlab.inria.fr/croco-ocean/croco/-/issues/38Deposit only, water concentration never attend zero in layer k=12022-09-08T10:51:37+02:00Solene Le GacDeposit only, water concentration never attend zero in layer k=1In an 1DV case without any current to observe the effect of deposit only.
The concentration in the bottom layer (k=1) remains at a very small value (~1E14), the other layers reach zeroIn an 1DV case without any current to observe the effect of deposit only.
The concentration in the bottom layer (k=1) remains at a very small value (~1E14), the other layers reach zeroMustangSolene Le GacSolene Le Gac2022-02-15https://gitlab.inria.fr/croco-ocean/croco/-/issues/41Number of allowed variables in Netcdf history file in case of 2D run2022-09-08T10:51:37+02:00Matthieu CaillaudNumber of allowed variables in Netcdf history file in case of 2D runIn https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/ncscrum.h#L1431 the variable NWRTHIS is not big enough anymore for 2D case (UNDEF SOLVE3D)
solved in 99b89c6b4246ff0d677c8bc282118bbd39429520In https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/ncscrum.h#L1431 the variable NWRTHIS is not big enough anymore for 2D case (UNDEF SOLVE3D)
solved in 99b89c6b4246ff0d677c8bc282118bbd39429520Bug fixMatthieu CaillaudMatthieu Caillaud2022-02-23https://gitlab.inria.fr/croco-ocean/croco/-/issues/39Mustang initialization - regroup calls2022-02-21T10:31:11+01:00Solene Le GacMustang initialization - regroup callsIn main.F there is 3 calls to MUSTANG initialization subroutines :
- `MUSTANG_initialization` : https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/main.F#L201
- `MUSTANG_init_sediment_main` : https://gitlab.inria.fr/croco-oc...In main.F there is 3 calls to MUSTANG initialization subroutines :
- `MUSTANG_initialization` : https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/main.F#L201
- `MUSTANG_init_sediment_main` : https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/main.F#L451
- `MUSTANG_compatibility` : https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/main.F#L817
MUSTANG_init_sediment_main is in module plug_MUSTANG_CROCO while MUSTANG_initialization and MUSTANG_compatibility are in module initMUSTANG.
And there is a call to MUSTANG_compatibility in the call to MUSTANG_init_sediment_main.
At least the last call seams useless (this is to check)
The goal should be a unique entry point to MUSTANG initialization via MUSTANG_init_sediment_main.
This could permit to avoid use of init module in main and group all calls in one.MustangSolene Le GacSolene Le Gac2022-03-01https://gitlab.inria.fr/croco-ocean/croco/-/issues/34activelayer in V12022-09-08T10:51:37+02:00Solene Le Gacactivelayer in V1In sed_MUSTANG_erosion (V1), see https://gitlab.inria.fr/croco-ocean/croco/-/blob/dev_2022_mustang/MUSTANG/sed_MUSTANG.F90#L3532
In this case, profsed is always equal to zero if k=ksmax+1 in the do loop line 3528
Remove active layer in V1In sed_MUSTANG_erosion (V1), see https://gitlab.inria.fr/croco-ocean/croco/-/blob/dev_2022_mustang/MUSTANG/sed_MUSTANG.F90#L3532
In this case, profsed is always equal to zero if k=ksmax+1 in the do loop line 3528
Remove active layer in V1MustangSolene Le GacSolene Le Gac2022-03-01https://gitlab.inria.fr/croco-ocean/croco/-/issues/33Mustang - V2 frmudcr2 with ero_option=32022-09-08T10:51:36+02:00Solene Le GacMustang - V2 frmudcr2 with ero_option=3In sed_MUSTANG_comp_tocr_mixsed, in V2 if ero_option = 3 there is conceptually no need of a frmudcr2 but in the code, it is still there
Structure of the subroutine to rebuildIn sed_MUSTANG_comp_tocr_mixsed, in V2 if ero_option = 3 there is conceptually no need of a frmudcr2 but in the code, it is still there
Structure of the subroutine to rebuildMustangSolene Le GacSolene Le Gac2022-03-01https://gitlab.inria.fr/croco-ocean/croco/-/issues/29Mustang - Gravels in mustangV22022-09-08T10:51:36+02:00Solene Le GacMustang - Gravels in mustangV2In subroutine sed_MUSTANG_comp_tocr_mixsed in mustangV2 (key_MUSTANG_V2), if there is a mesh with only gravels, the suspension is disable (sed_tocr_mixsed=1000.0_rsh).
A trick has been introduct but is not clean, see https://gitlab.inri...In subroutine sed_MUSTANG_comp_tocr_mixsed in mustangV2 (key_MUSTANG_V2), if there is a mesh with only gravels, the suspension is disable (sed_tocr_mixsed=1000.0_rsh).
A trick has been introduct but is not clean, see https://gitlab.inria.fr/croco-ocean/croco/-/blob/dev_2022_mustang/MUSTANG/sed_MUSTANG.F90#L3730
A loop is done from gravels indexes rather than sand but this is not consistant with the rest of the codeMustangSolene Le GacSolene Le Gac2022-03-01https://gitlab.inria.fr/croco-ocean/croco/-/issues/42Mustang branch CVTK specific tests2022-04-04T17:32:52+02:00Solene Le GacMustang branch CVTK specific testsAdapt specific test cases in cvtk for development purpose on mustang
The changes in CVTK are not to be merged in master.Adapt specific test cases in cvtk for development purpose on mustang
The changes in CVTK are not to be merged in master.MustangSolene Le GacSolene Le Gac2022-03-15https://gitlab.inria.fr/croco-ocean/croco/-/issues/52Mustang - delete corfluer1/22022-04-04T17:26:32+02:00Solene Le GacMustang - delete corfluer1/2Code cleaning, parameters are not used :
- corfluer1=0.01 ! correction factors for erosion flux computations : Increases the erosion flow when the concentration of mud in the sediment is low (mud cream)
- corfluer2=350. !...Code cleaning, parameters are not used :
- corfluer1=0.01 ! correction factors for erosion flux computations : Increases the erosion flow when the concentration of mud in the sediment is low (mud cream)
- corfluer2=350. ! corfluero=1.+corfluer1*MAX(0.0_rsh,corfluer2-csed_tot_surface) typically, increase erosion flow if Crelmud <350 g/L
After checking with F.Grasso and P.Le Hir, they are to be deletedMustangSolene Le GacSolene Le Gac2022-03-30https://gitlab.inria.fr/croco-ocean/croco/-/issues/28Mass source point2022-05-30T19:02:36+02:00Matthieu CaillaudMass source pointPossibility to add a source point as a volume vertical influx. With this feature there is no need to take care of the position of the source with the mask and a source can be added anywhere on the grid. The outflow is applied at rho point.Possibility to add a source point as a volume vertical influx. With this feature there is no need to take care of the position of the source with the mask and a source can be added anywhere on the grid. The outflow is applied at rho point.new branchMatthieu CaillaudMatthieu Caillaud2022-04-01https://gitlab.inria.fr/croco-ocean/croco/-/issues/56TEST CASES : TIDAL_FLAT wrong temp and salt at west boundary, DUNE & SED_TOY ...2022-04-08T12:02:37+02:00Solene Le GacTEST CASES : TIDAL_FLAT wrong temp and salt at west boundary, DUNE & SED_TOY wrong salt initializationFor TIDAL_FLAT, salt oscillations are observed at west boundary. Probably incompatibility between bdry forcing and initial value
For DUNE and SED_TOY, salt is initialize at 0.For TIDAL_FLAT, salt oscillations are observed at west boundary. Probably incompatibility between bdry forcing and initial value
For DUNE and SED_TOY, salt is initialize at 0.Solene Le GacSolene Le Gac2022-04-15https://gitlab.inria.fr/croco-ocean/croco/-/issues/53Mustang - l_bedload, ibedload1/ibedload22022-09-08T10:51:36+02:00Solene Le GacMustang - l_bedload, ibedload1/ibedload2Possible confusion if l_bedload==false for a sediment class between ibedload1 and ibedload2
>> add a test at initialization to stop and warn user of incoherence in parametersPossible confusion if l_bedload==false for a sediment class between ibedload1 and ibedload2
>> add a test at initialization to stop and warn user of incoherence in parametersMustangSolene Le GacSolene Le Gac2022-04-15https://gitlab.inria.fr/croco-ocean/croco/-/issues/40Mustang sed_skinstress2022-04-08T12:06:30+02:00Solene Le GacMustang sed_skinstressA redesign of sed_skinstress subroutine https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/MUSTANG/sed_MUSTANG_CROCO.F90#L433 will permit to :
- homogenize variable names with english names (change tenfon*, frofon*...) (see also cr...A redesign of sed_skinstress subroutine https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/MUSTANG/sed_MUSTANG_CROCO.F90#L433 will permit to :
- homogenize variable names with english names (change tenfon*, frofon*...) (see also croco-ocean/croco#32)
- highlight more clearly the user choice in the code from each cppkey : BBL, key_MUSTANG_tenfonUbar, key_tenfon_upwind, WAVE_OFFLINE
- update documentation of mustang on this subjectMustangSolene Le GacSolene Le Gac2022-04-15https://gitlab.inria.fr/croco-ocean/croco/-/issues/54Mustang - ESTUARY test case2022-09-26T10:13:16+02:00Solene Le GacMustang - ESTUARY test caseAdd a new test case with a schematized estuary (from MARS corresponding test case)Add a new test case with a schematized estuary (from MARS corresponding test case)MustangSolene Le GacSolene Le Gac2022-04-30