croco issueshttps://gitlab.inria.fr/croco-ocean/croco/-/issues2024-03-18T08:11:33+01:00https://gitlab.inria.fr/croco-ocean/croco/-/issues/129branch dev_2022_biolink: analytics tests with CVTK failed for estuary/tidal_f...2024-03-18T08:11:33+01:00Camille Mazoyerbranch dev_2022_biolink: analytics tests with CVTK failed for estuary/tidal_flat testcases (mustang) + RIP/SandbarIn biolink branch, some CVTK tests are now working on my laptop (gfortran 9.4 ubuntu 20.04) . Tests that don't work are:
- **RIP and Sandbar** have problems (blow up, vmax=NaN ) and need to be debug.
- **Estuary and Tidal_flat** : m...In biolink branch, some CVTK tests are now working on my laptop (gfortran 9.4 ubuntu 20.04) . Tests that don't work are:
- **RIP and Sandbar** have problems (blow up, vmax=NaN ) and need to be debug.
- **Estuary and Tidal_flat** : module file plug_mustang_croco.F90 is missing according to those two tests. @x-SLeGac , can you look at it?
```
==============================
TESTING ESTUARY :
==============================
- SOURCE_CROCO=/home/mazoyer/Documents/PROJETS_SRC/CROCO/CROCO_DEBUG_gitlabrunner/croco/builds/0/project-0/OCEAN
- Testing CROCO Rev6063
- Create and setup dir. : ESTUARY
Create the link between TESTROOT . and /home/mazoyer/Documents/PROJETS_SRC/CROCO/CROCO_DEBUG_gitlabrunner/croco/builds/0/project-0/.datawork/KTEST/ESTUARY
- Run Tests
- Compilation failure for ESTUARY : SERIAL...
- Compilation failure for ESTUARY : MPI...
```
```
gfortran -c -O0 -mcmodel=medium -g -fdefault-real-8 -fdefault-double-8 -std=legacy -fbacktrace -fbounds-check -finit-real=nan -finit-integer=8888 main_.f -o main.o
main_.f:4:13:
4 | USE plug_MUSTANG_CROCO, ONLY : mustang_init_main
| 1
Fatal Error: Cannot open module file ‘plug_mustang_croco.mod’ for reading at (1): Aucun fichier ou dossier de ce type
compilation terminated.
```Bug fixSolene Le GacSolene Le Gachttps://gitlab.inria.fr/croco-ocean/croco/-/issues/147Harmless inconsistency in create_config.bash2024-03-13T18:05:07+01:00Rachid BenshilaHarmless inconsistency in create_config.bashWhen creating a configuration in dev mod, even if we choose not to use the croco_tools, some operations are done on the matlab files (start.m etc). No practical consequences, the config is created anyway but the script print some errors,...When creating a configuration in dev mod, even if we choose not to use the croco_tools, some operations are done on the matlab files (start.m etc). No practical consequences, the config is created anyway but the script print some errors, which is scary
Fix: update the matlab files only if copy_tools=1Bug fixRachid BenshilaRachid Benshilahttps://gitlab.inria.fr/croco-ocean/croco/-/issues/103ncjoin with simple precision2024-02-16T16:20:58+01:00Rachid Benshilancjoin with simple precisionncjoin is not working with single precision, so we force output in double in cppdefS_dev.h since v1.3
The previous modification (conversion of real8 to real4 when calling assembly_real) is actually not working, and generate empty files. ...ncjoin is not working with single precision, so we force output in double in cppdefS_dev.h since v1.3
The previous modification (conversion of real8 to real4 when calling assembly_real) is actually not working, and generate empty files. This modification was done bacause of the argument mismatch when calling assembly_real, which turned to a compilation error with gfortran >= 10. The modification is not needed if we use the compilation option -std=legacy, so we can revert it.
Note that relying on a compilation option is questionable.Bug fixRachid BenshilaRachid Benshilahttps://gitlab.inria.fr/croco-ocean/croco/-/issues/116Missing block in PISCESv2 namelist_sediment_cfg and _ref in CROCO v1.32023-05-06T11:00:33+02:00Renaud PersonMissing block in PISCESv2 namelist_sediment_cfg and _ref in CROCO v1.3@x-JMcGov encountered an error at runtime when switching to CROCO v1.3 where the namelist_sediment default file (as included in /PISCES/SED) was missing the following block at the very end (i.e. the last block that was previously availab...@x-JMcGov encountered an error at runtime when switching to CROCO v1.3 where the namelist_sediment default file (as included in /PISCES/SED) was missing the following block at the very end (i.e. the last block that was previously available to read from the namelist file was nam_rst)
!-----------------------------------------------------------------------
&nam_output ! parameters for outputing the sediment module
!-----------------------------------------------------------------------
ldefsedpis_avg = .true. ! write averaged output variables
cn_sedwri_out = "output_sed.nc" ! name of the input restart file name of the sediment module
nrpfsedpis_avg = 0 ! Frequency of the averaged outputs
nwrtsedpis_avg = 24 ! Frequency of the averaged outputs
ntssedpis_avg = 1 ! ???
/
@x-JMcGov found the missing block correctly formatted here (for NEMO-PISCES):
http://forge.ipsl.jussieu.fr/nemo/changeset/14306#file2
The corresponding block of text is read by PISCES/SED/sedini.F90 in line 425
@x-JMcGov became aware of this fault:
1) by switching on key_sediment for PISCES, and
2) encountering a runtime error as follows:
croco1 0000000000C8B0BE setavg_sed_mp_set 2149 setavg_sed_.f90
where the expression
(mod(ilc-1,nwrtsedpis_avg).eq.1)
was returning a "division by zero" error as nwrtsedpis_avg had not been set and thus had been defaulted to zero.Bug fixRenaud PersonRenaud Personhttps://gitlab.inria.fr/croco-ocean/croco/-/issues/104CI broken for reg_run2023-02-17T10:10:02+01:00Solene Le GacCI broken for reg_runOn master branch, reg_run do not pass with error on compilation for BRYPISCES22, here is the error:
``` fortran
p4zflx.o
cpp -traditional -DLinux -P -I/usr/include -ICROCOFILES/AGRIF_INC p2zlim.F90 > p2zlim_.f90
gfortran -c -O0 -g -fdef...On master branch, reg_run do not pass with error on compilation for BRYPISCES22, here is the error:
``` fortran
p4zflx.o
cpp -traditional -DLinux -P -I/usr/include -ICROCOFILES/AGRIF_INC p2zlim.F90 > p2zlim_.f90
gfortran -c -O0 -g -fdefault-real-8 -fdefault-double-8 -std=legacy -fbacktrace -fbounds-check -finit-real=nan -finit-integer=8888 p2zlim_.f90 -o p2zlim.o
p2zlim_.f90:397:132:
xnanono3(ji,jj,jk) = t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpno3) / ( zconc0n + t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpno3) )
1
Error: Line truncated at (1) [-Werror=line-truncation]
p2zlim_.f90:397:132:
xnanono3(ji,jj,jk) = t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpno3) / ( zconc0n + t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpno3) )
1
Error: Invalid form of array reference at (1)
p2zlim_.f90:398:132:
xlimnfe (ji,jj,jk) = t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpfer) / ( zconcnf + t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpfer) )
1
Error: Line truncated at (1) [-Werror=line-truncation]
p2zlim_.f90:398:132:
xlimnfe (ji,jj,jk) = t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpfer) / ( zconcnf + t(ji,jj,N+1-jk,nnew,itemp+ntrc_salt+jpfer) )
1
Error: Invalid form of array reference at (1)
f951: some warnings being treated as errors
make: *** [Makedefs:22: p2zlim.o] Error 1
```
Complete log file attached
Under investigation, it seems it is just a line length pb on https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/PISCES/p2zlim.F90#L110 due to change with define see : https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/PISCES/ocean2pisces.h90#L51Bug fixhttps://gitlab.inria.fr/croco-ocean/croco/-/issues/105Issue with time units with ANA_INITIAL and USE_CALENDAR2023-02-16T09:35:00+01:00Mathieu Le CorreIssue with time units with ANA_INITIAL and USE_CALENDARWhen starting simulation with ANA_INITIAL and when using USE_CALENDAR, the time units is defined as it should be (format seconds since YYYY/MM/DD hh:mm:ss)When starting simulation with ANA_INITIAL and when using USE_CALENDAR, the time units is defined as it should be (format seconds since YYYY/MM/DD hh:mm:ss)Bug fixMathieu Le CorreMathieu Le Correhttps://gitlab.inria.fr/croco-ocean/croco/-/issues/99MASTER- Blowup wet_dry2023-01-25T16:26:51+01:00Mathieu Le CorreMASTER- Blowup wet_dryThere was a blowup issue when using WET_DRY option.
This was related to negative value of h+zeta in zetabc.F.
The update modifies u/v-mask near the boundaries in u/v2dbc.F by computing it at knew time step instead of kstp(to make it mo...There was a blowup issue when using WET_DRY option.
This was related to negative value of h+zeta in zetabc.F.
The update modifies u/v-mask near the boundaries in u/v2dbc.F by computing it at knew time step instead of kstp(to make it more responsive). Another correction has been made in zetabc.F to avoid problem when h+zeta<0Bug fixMathieu Le CorreMathieu Le Correhttps://gitlab.inria.fr/croco-ocean/croco/-/issues/80bug in step3d_t.F : minimum stratification imposed = 02022-11-24T17:19:39+01:00Christophe Hourdinbug in step3d_t.F : minimum stratification imposed = 0croco doesn't compile with floating point exception debug options
- ifort : -fpe0
or
- gfortran : -ffpe-trap=invalid,zero,overflow -ffpe-summary=invalid,zero,overflow
due to a zero cff minimum stratification value in step3d_t.F.
...croco doesn't compile with floating point exception debug options
- ifort : -fpe0
or
- gfortran : -ffpe-trap=invalid,zero,overflow -ffpe-summary=invalid,zero,overflow
due to a zero cff minimum stratification value in step3d_t.F.
Maybe change
` cff = min( 1./dRz,-1.E-14 ) ! minimum stratification imposed`
By
` cff = 1./min(dRz, -1.E-14) ! minimum stratification imposed`Bug fixhttps://gitlab.inria.fr/croco-ocean/croco/-/issues/41Number of allowed variables in Netcdf history file in case of 2D run2022-09-08T10:51:37+02:00Matthieu CaillaudNumber of allowed variables in Netcdf history file in case of 2D runIn https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/ncscrum.h#L1431 the variable NWRTHIS is not big enough anymore for 2D case (UNDEF SOLVE3D)
solved in 99b89c6b4246ff0d677c8bc282118bbd39429520In https://gitlab.inria.fr/croco-ocean/croco/-/blob/master/OCEAN/ncscrum.h#L1431 the variable NWRTHIS is not big enough anymore for 2D case (UNDEF SOLVE3D)
solved in 99b89c6b4246ff0d677c8bc282118bbd39429520Bug fixMatthieu CaillaudMatthieu Caillaud2022-02-23https://gitlab.inria.fr/croco-ocean/croco/-/issues/51DIAGNOSTICS_TS and SEDIMENT2022-06-17T09:12:40+02:00Rachid BenshilaDIAGNOSTICS_TS and SEDIMENTCompilation error with DIAGNOSTICS_TS and SEDIMENT => a loop is not closed in sediment.F when calculating the trendCompilation error with DIAGNOSTICS_TS and SEDIMENT => a loop is not closed in sediment.F when calculating the trendBug fixRachid BenshilaRachid Benshilahttps://gitlab.inria.fr/croco-ocean/croco/-/issues/50Bug in with average and sediment2022-06-17T09:12:40+02:00Rachid BenshilaBug in with average and sedimentAveraged outputs (cpp AVERAGES) are not correct in wrt_avg when using BEDLOAD without SUSPLOAD.Averaged outputs (cpp AVERAGES) are not correct in wrt_avg when using BEDLOAD without SUSPLOAD.Bug fixRachid BenshilaRachid Benshilahttps://gitlab.inria.fr/croco-ocean/croco/-/issues/60online_bulk_var : add definition of atm pressure for ECMWF2022-06-17T09:12:40+02:00Matthieu Caillaudonline_bulk_var : add definition of atm pressure for ECMWFThe section of atm pressure is missing for ECMWFThe section of atm pressure is missing for ECMWFBug fixMatthieu CaillaudMatthieu Caillaud2022-06-08https://gitlab.inria.fr/croco-ocean/croco/-/issues/15bad termination after blow up with NBQ+AGRIF options2022-03-31T19:02:37+02:00Laurent ROBLOUbad termination after blow up with NBQ+AGRIF optionsAfter STEP3D_FAST blow up (run with NBQ+AGRIF options), the run is not properly terminated by croco binary, leading to a (massive) loss of computing hours.After STEP3D_FAST blow up (run with NBQ+AGRIF options), the run is not properly terminated by croco binary, leading to a (massive) loss of computing hours.Bug fixCyril NguyenCyril Nguyen2019-03-15https://gitlab.inria.fr/croco-ocean/croco/-/issues/45Bug in bulk flux ONLINE in v1.22022-03-09T15:34:18+01:00Swen JullienBug in bulk flux ONLINE in v1.2In v1.2 when using ONLINE bulk wspd is not computed. It is therefore initialized to 0 (I assume) and fluxes are strongly underestimated.In v1.2 when using ONLINE bulk wspd is not computed. It is therefore initialized to 0 (I assume) and fluxes are strongly underestimated.Bug fixhttps://gitlab.inria.fr/croco-ocean/croco/-/issues/47run_croco_inter.bash : with AGRIF wrong calculation of DT for child2022-03-03T18:08:38+01:00Gildas Cambonrun_croco_inter.bash : with AGRIF wrong calculation of DT for childQuand le DT est divisé par 3 pour l'enfant, il n'est pas remis à sa valeur d'origine pour le mois suivant du parent. Et les pas de temps ne font que diminuer de plus en plus...
Corrections :
DT0=$DT
LEVEL=0
while [[ $LEVEL !=...Quand le DT est divisé par 3 pour l'enfant, il n'est pas remis à sa valeur d'origine pour le mois suivant du parent. Et les pas de temps ne font que diminuer de plus en plus...
Corrections :
DT0=$DT
LEVEL=0
while [[ $LEVEL != $NLEVEL ]]; do
if [[ ${LEVEL} == 0 ]]; then
ENDF=
else
ENDF=.${LEVEL}
NUMTIMES=$((AGRIF_REF * NUMTIMES))
DT=$((DT / AGRIF_REF))
fi
...
LEVEL=$((LEVEL + 1))
done
DT=$DT0Bug fixGildas CambonGildas Cambon