Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • allgo allgo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 81
    • Issues 81
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • allgoallgo
  • allgoallgo
  • Merge requests
  • !47

Bug fix: OAuth2 registration

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged BERJON Matthieu requested to merge oauth-registration into django Jun 19, 2018
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 7

The Oauth registration was buggy for several reasons. The links used in the templates were the wrong one inhibiting the correct behaviour. The site ID configuration was wrong. This part is fixed by updating the migration script. The current system needs at least to have the ALLGO_SITE_ID set up corresponding to the actual URL of the website (http://localhost: in development https://allgo.inria.fr in production. The ACCOUNT_USERNAME_VALIDATORS was raising an error on the Oauth registration and has been removed. No known bug were introduced by doing that.

The login and signup templates have been rewritten in order to have a smoother and nicer integration in the current website. Moreover, the focus has been made on the OAuth registration (that's what users see first).

The user admin part has been modified in order to display the possibility to change the password in case the user has set up a local account on the service or the management of its Oauth connections (redirecting to the connextions.html template provided by the django Oauth plugin and integrated in the website.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: oauth-registration