allgo merge requestshttps://gitlab.inria.fr/allgo/allgo/-/merge_requests2018-05-09T16:26:34+02:00https://gitlab.inria.fr/allgo/allgo/-/merge_requests/24Issue#792018-05-09T16:26:34+02:00GUILLOU BenoîtIssue#79Les premieres d'ebauches d'implementations d'ACL , a ne pas merger ..
Eventuellement a regarder ( recuperer les squelettes de formulaires , voir les emplacements des fichiers , les classes a coder dans le futur etc .. )Les premieres d'ebauches d'implementations d'ACL , a ne pas merger ..
Eventuellement a regarder ( recuperer les squelettes de formulaires , voir les emplacements des fichiers , les classes a coder dans le futur etc .. )0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/23Issue#812018-05-09T16:26:46+02:00GUILLOU BenoîtIssue#810.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/22Issue#842018-05-09T16:27:18+02:00GUILLOU BenoîtIssue#84This bugfix works as intended , meaning the resizing of the fields when the window becomes really thin , doesn't cut the titles of the fields no more , and the end of the fields now sit flush with the border of the frame ...
We *could* a...This bugfix works as intended , meaning the resizing of the fields when the window becomes really thin , doesn't cut the titles of the fields no more , and the end of the fields now sit flush with the border of the frame ...
We *could* add a little padding on each sides to make the resize more pleasing , but if we only care about functionality , this fix does the trick !0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/21Issue#docsimprov2018-05-09T16:27:21+02:00GUILLOU BenoîtIssue#docsimprovThis update contains a new folder tutorial , with all the edited pictures i used in the wiki pages i created for the dev environment smtpsink setup , and the webapp upload tutorial ..
It's always better to have those kind of files in sev...This update contains a new folder tutorial , with all the edited pictures i used in the wiki pages i created for the dev environment smtpsink setup , and the webapp upload tutorial ..
It's always better to have those kind of files in several places in case of a crash !
you never know ...Plus the doc folder is made for it anyway !0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/20Issue#802018-05-09T16:27:27+02:00GUILLOU BenoîtIssue#80this merge request works pretty well in most forms .
You will tell me if that's exactly what you wanted or if it can be improved !this merge request works pretty well in most forms .
You will tell me if that's exactly what you wanted or if it can be improved !0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/19Issue#822018-05-09T16:27:34+02:00GUILLOU BenoîtIssue#82The job creation permission filters functions ( i.e the user is redirected to a 403 page if he is not allowed ) , but the job is still created
However the job show filter functions perfectly , the user cannot in any case access a job cr...The job creation permission filters functions ( i.e the user is redirected to a 403 page if he is not allowed ) , but the job is still created
However the job show filter functions perfectly , the user cannot in any case access a job created by another user , which is good ...
This version might surely not merge , but i submit it for a hint about why the redirection in the job controller doesn't stop the action create to be executed !0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/18Issue#1182017-06-29T15:00:34+02:00GUILLOU BenoîtIssue#118I push this version only for you to evaluate .... You'll see in the edit the email field is blank ....well i didn't succeed to force the damn _form to display the email address even though the value of the field is affected IN the _form'...I push this version only for you to evaluate .... You'll see in the edit the email field is blank ....well i didn't succeed to force the damn _form to display the email address even though the value of the field is affected IN the _form's markup and not in the renders like the previous version , i still don't get that behavior of the partials ...But even though the field is blank it doesn't erase the mail of the owner of the app0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/17Issue#1182017-05-24T18:06:27+02:00GUILLOU BenoîtIssue#118Removed all the changes that were inconveniently applied to my old branch for this issue
still works as usualRemoved all the changes that were inconveniently applied to my old branch for this issue
still works as usual0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/16Issue#1162017-06-20T14:50:00+02:00GUILLOU BenoîtIssue#116The codefix to implement the button with the right functionalities , has been extensively tested :
- the copiable token field works ( with the ", :readonly => true" , option in the f.field markup ).
- the refresh of the page doesn't ...The codefix to implement the button with the right functionalities , has been extensively tested :
- the copiable token field works ( with the ", :readonly => true" , option in the f.field markup ).
- the refresh of the page doesn't regenerate the token , displays only the token that is actually in the database .
- the form submits flawlessly as it used to and the new token generated at a click of the button and puts it in the database ( when coming back to the form page
the new token is clearly displayed )
- clicking on the regenerate token button doesn't put the new token in the base , only the submit button does it , so if you click "regenerate token" you'll see the
possible new token , but if you refresh the page , the token turns back to what is in the database ....
So you can click and click the regenerate button again and again until you find the one that suits you without fear of it beeing entered into the base prematurely .
- route.rb isn't affected at all0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/15Issue#1182017-05-23T09:41:17+02:00GUILLOU BenoîtIssue#118The method to override the content of the symbol value at the rendering of the form is pretty straightforward ...
in the edit.html.erb you have to add the option : <% render "form" , :value ' ' %>
whereas in the new.html.erb you have...The method to override the content of the symbol value at the rendering of the form is pretty straightforward ...
in the edit.html.erb you have to add the option : <% render "form" , :value ' ' %>
whereas in the new.html.erb you have to write <% render "form" , :value current_user.email%>
then in the partial you just have to set things in this fashion ;
<%= ........... :value value%>
Works flawlessly ...0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/13added fix to issue#852017-05-24T15:28:48+02:00GUILLOU Benoîtadded fix to issue#85Tous les onglets on été affectés d'un nom adapté ...Y compris les sous cathégories .
Je pense que c'est propre , tu me diras .Tous les onglets on été affectés d'un nom adapté ...Y compris les sous cathégories .
Je pense que c'est propre , tu me diras .0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/12Issue#192017-05-11T14:50:21+02:00GUILLOU BenoîtIssue#19With the <% end %> at the right place to end the test case "NEW" , "WAITING" , "RUNNING" before the ' report a problem ' button markup ..It stays apprearant when the job state is DONE ...Pretty obvious !With the <% end %> at the right place to end the test case "NEW" , "WAITING" , "RUNNING" before the ' report a problem ' button markup ..It stays apprearant when the job state is DONE ...Pretty obvious !0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/11added directories containing faq reference report tutorials2017-05-03T18:07:25+02:00GUILLOU Benoîtadded directories containing faq reference report tutorialsadded some internal reference directories containing 4 directories indicated to stock all the developpers information files .added some internal reference directories containing 4 directories indicated to stock all the developpers information files .0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/10fix added to [issue#99]2017-04-20T20:42:52+02:00GUILLOU Benoîtfix added to [issue#99]Added a timeout of 0.5 seconds to the TCP connect procedure in rails/lib/docker_adapter.rb .
As specified in the bug ticket .
Should work just fine .Added a timeout of 0.5 seconds to the TCP connect procedure in rails/lib/docker_adapter.rb .
As specified in the bug ticket .
Should work just fine .0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/9added fix to [issue #77]2017-06-20T16:48:28+02:00GUILLOU Benoîtadded fix to [issue #77]The Gemfile , has been improved with LOTS of information comments about the gems used as well as the places where they are used in the code ..
The bower.json hasn't been commented though because it is impossible to comment it for some in...The Gemfile , has been improved with LOTS of information comments about the gems used as well as the places where they are used in the code ..
The bower.json hasn't been commented though because it is impossible to comment it for some intercompatibity reasons , but it's not a HUGE issue since there are only 4 or 5 libraries used that are pretty common ...0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/8added a button report a problem to show.html.erb , fix to[issue#19]2017-05-02T15:41:13+02:00GUILLOU Benoîtadded a button report a problem to show.html.erb , fix to[issue#19]The button don't have a really lenghty and automatic body , but filling the body is more of a design issue to be decided than a real fix to implement ... At least now the user has a button " report a problem" that works and has an auto...The button don't have a really lenghty and automatic body , but filling the body is more of a design issue to be decided than a real fix to implement ... At least now the user has a button " report a problem" that works and has an automatic mail adress ...Which is what we wanted0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/7deleted show_jobs.html.erb , edited _navbar.html.erb that works !2017-04-20T20:25:49+02:00GUILLOU Benoîtdeleted show_jobs.html.erb , edited _navbar.html.erb that works !deleted show_jobs.html.erb , edited _navbar.html.erb , and updated seeds.rb , fix to issue#effaceshowjobsseeds
Correction of the error of the first merge request on this subject !deleted show_jobs.html.erb , edited _navbar.html.erb , and updated seeds.rb , fix to issue#effaceshowjobsseeds
Correction of the error of the first merge request on this subject !0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/6Erased the file show_jobs.html.erb , edited the _navbar.html.erb , and the see…2017-04-12T15:58:26+02:00GUILLOU BenoîtErased the file show_jobs.html.erb , edited the _navbar.html.erb , and the see…I erased the markup responsible for the extra "My jobs" page in the _navbar.html.erb , plus erased the file show_jobs.html.erb , and updated the seeds.rb file with my log in info , which will be more convenient ...I erased the markup responsible for the extra "My jobs" page in the _navbar.html.erb , plus erased the file show_jobs.html.erb , and updated the seeds.rb file with my log in info , which will be more convenient ...0.5https://gitlab.inria.fr/allgo/allgo/-/merge_requests/5Modification to the help button, avoids hard coded links2017-04-04T11:17:06+02:00GUILLOU BenoîtModification to the help button, avoids hard coded linksfix #94fix #940.5BAIRE AnthonyBAIRE Anthonyhttps://gitlab.inria.fr/allgo/allgo/-/merge_requests/4Updated notes on fedora versions' installations README.md2017-05-03T18:33:25+02:00GUILLOU BenoîtUpdated notes on fedora versions' installations README.md**This is a transitory modification of the project's markdown page , i think the best way to implement my fedora add ons would be to make lightly colored areas on the page , to distinguish it better from the common operating system proce...**This is a transitory modification of the project's markdown page , i think the best way to implement my fedora add ons would be to make lightly colored areas on the page , to distinguish it better from the common operating system procedures ...Further discussions are required about the design of the page ...**0.5