1. 20 Sep, 2018 2 commits
  2. 19 Sep, 2018 2 commits
    • BAIRE Anthony's avatar
      support legacy urls · 00bde819
      BAIRE Anthony authored
      close #249
      00bde819
    • BAIRE Anthony's avatar
      fix setting Webapp.memory_limit in the UI · 88a62c53
      BAIRE Anthony authored
      
      - add config key ALLGO_WEBAPP_DEFAULT_MEMORY_LIMIT_MB to set the
        default memory limit for newly created webapps
      
      - add memory limit field in WebappUpdate
      
      - display memory_limit in megabytes in the UI (through the
        memory_limit_mb form field)
      
      - disable the memory_limit_mb widget and ignored the posted value
        when user is not superuser
      
      - forbid negative value in the model
      
      - make the memory limit field required in the forms
      88a62c53
  3. 18 Sep, 2018 4 commits
  4. 17 Sep, 2018 3 commits
    • BAIRE Anthony's avatar
      remove WebappVersion.url · ade74d2d
      BAIRE Anthony authored
      (was not used at all)
      ade74d2d
    • BAIRE Anthony's avatar
      fix integrity issue · 914e9efc
      BAIRE Anthony authored
      because django sets a foreign key constraint on sandbox_version_id
      we may have issues if it refers to a version we want to delete
      914e9efc
    • BAIRE Anthony's avatar
      derive docker tags names from WebappVersion.id · b7b30d3e
      BAIRE Anthony authored
      With this change docker images are no longer
      named as: <Webapp.docker_name>:<WebappVersion.number>
      but       <Webapp.docker_name>:id</WebappVersion.id>
      
      This is only for storage, for the user we still present the image as
      <Webapp.docker_name>:<WebappVersion.number>
      
      There are multiple reasons to do that:
      - this simplifies the controller design, because docker images are no
        longer replaced (once an image is committed with tag, 'id<SOMETHING>'
        it won't be modified anymore) -> thus it is no longer necessary to
        track the image state carefully (when pushing/pulling from/to the
        registry)
      - this prevent reusing dangling images from a removed webapp (because we
        now have a strong guarantee that the image tags are unique)
      - this will avoid nasty race conditions when we implement direct 'push'
        to the registry (because we then assign the new image id before the
        manifest is actually pushed, if a push and commit are done in the same
        time we will keep the latest one, i.e. with the highest id)
      - this will make easy to implement image recovery: we can keep removed
        images in the registry for some time (eg: 1 month) before they are
        really deleted
      
      Note: the REPLACED state is no longer transient (since we now keep the
      replaced images in the db and since we may still have remaining
      job/sandboxes using them). Maybe we can rename it as DELETED when we
      implement #265.
      b7b30d3e
  5. 12 Sep, 2018 2 commits
  6. 10 Sep, 2018 1 commit
  7. 06 Sep, 2018 2 commits
  8. 20 Aug, 2018 1 commit
    • BERJON Matthieu's avatar
      Updating the tag views · 9f60450c
      BERJON Matthieu authored
      
      
      I updated the tag views by importing the `Tag` model provided by the
      Taggit plugin, deleted the `WebappTag` model and `TagForm` form that are
      obsolete.
      I updated the `WebappUpdate` view to follow the recommendation given by
      the Taggit plugin documentation. The `TagList` now uses directly the
      `Tag` model and send both the tag fields and a count of each tag
      occurence.
      I removed the `TagAdd` list that is obsolete. I updated the
      `TagWebappList` that returns simply a list of all `Webapp`objects for a
      given tag.
      Signed-off-by: BERJON Matthieu's avatarMatthieu Berjon <matthieu.berjon@inria.fr>
      9f60450c
  9. 16 Aug, 2018 1 commit
  10. 08 Aug, 2018 1 commit
  11. 07 Aug, 2018 7 commits
  12. 01 Aug, 2018 6 commits
    • BAIRE Anthony's avatar
      check user permission in the sandbox panel · c6d282fd
      BAIRE Anthony authored
      c6d282fd
    • BAIRE Anthony's avatar
      fix redirect to the same page · 1fc178d5
      BAIRE Anthony authored
      (chromium does support empty "Location:" header)
      1fc178d5
    • BAIRE Anthony's avatar
      add flash messages · 2a11b390
      BAIRE Anthony authored
      2a11b390
    • BAIRE Anthony's avatar
      implement version selection & validation in the sandbox panel · b5bad170
      BAIRE Anthony authored
      - form reformatted as a grid (using class form-row)
      - when replacing a version
        - select the version used for starting the current sandbox
        - initialise the "changelog" field with the previous changelog
          of the version being replaced
      - when creating a new version
        - initialise the "changelog" field with an empty value
        - raise an error if the entered version already exists
          (prevents accidental overwriting by the user)
      - report commit result in a flash message
      b5bad170
    • BERJON Matthieu's avatar
      Bug fix: reverse on webapp creation redirection · c29bffe4
      BERJON Matthieu authored and BAIRE Anthony's avatar BAIRE Anthony committed
      
      
      The redirection for a successful webapp creation was wrong and created
      an error. I fixed it by giving te right handle (i.e
      `webapp_sandox_panel`).
      Signed-off-by: BERJON Matthieu's avatarMatthieu Berjon <matthieu.berjon@inria.fr>
      c29bffe4
    • BAIRE Anthony's avatar
      refactor the sandbox management panel · 9bf09947
      BAIRE Anthony authored
      - all sandbox actions a made from the same endpoint, so i renamed it as
        WebappSandboxPanel. It is an endpoint that accept GET and POST methods
      - GET is rendered using TemplateView (nothing magic)
      - POST is has an ad-hoc implementation that handles sandbox
        actions (start, commit, rollback, retry, abort)
      - all POST actions are followed with an HTTP redirect (to make a GET)
        so that actions are repeated if the user refresh his browser window
      - I changed the initial status of newly created webapps to IDLE because
        power users who upload their docker image do not need to start a
        sandbox
      
      It is not finished, there are many FIXMEs/TODOs but it is working.
      9bf09947
  13. 31 Jul, 2018 7 commits
  14. 26 Jul, 2018 1 commit
    • BERJON Matthieu's avatar
      Updating the success and error messages · 4e315cda
      BERJON Matthieu authored
      
      
      I fixed the bug in two `DeleteView` views. The `SuccessMessageMixin`
      doesn't work with `DeleteView` views because it's hooked to the
      `form_valid` method which doesn't exist in this particular view.
      
      I took the opportunity to rewrite the other success or error messages in
      the other views in order to have something a bit clearer and easier to
      read.
      Signed-off-by: BERJON Matthieu's avatarMatthieu Berjon <matthieu.berjon@inria.fr>
      4e315cda