add an intermediate 'user_need_validation' page for email validation

There are multiple reasons:
- we can use the same page for validating the 'Terms of Use'
- the user may already have received the message
- we should do the same validation on the API too (but API should not
  send any email but just display the error message)

django/allgo/main/mixins.py

@@ -47,11 +47,7 @@ class AllgoValidAccountMixin:
 
             if not any(addr.verified for addr in email_addresses):
                 # user has no verified address
-                # TODO: do not send the emails immediately but display a page
-                #       with a link to send the email 
-                for addr in email_addresses:
-                    addr.send_confirmation(request)
-                return redirect("account_email_verification_sent")
+                return redirect("main:user_need_validation")
 
         return super().dispatch(request, *args, **kwargs)
 

django/allgo/main/urls.py

@@ -74,6 +74,7 @@ urlpatterns = [
     url(r'^profile/ssh/add$', views.UserSSHAdd.as_view(), name='user_ssh_add'),
     url(r'^profile/ssh/delete$', views.UserSSHDelete.as_view(), name='user_ssh_delete'),
     url(r'^profile/password$', views.UserPasswordUpdate.as_view(), name='user_password'),
+    url(r'^profile/need_validation$', views.UserNeedValidation.as_view(), name='user_need_validation'),
 
     #  url(r'^runners/$', views.RunnerList.as_view(), name='runner_list'),
     #  url(r'^runners/_add$', views.RunnerCreate.as_view(), name='runner_create'),

django/allgo/main/views.py

@@ -417,8 +417,10 @@ class WebappImport(ProviderAccessMixin, SuccessMessageMixin, FormView):
 
             # ensure the user email is verified
             if not email_addr.verified:
-                email_addr.send_confirmation(request)
-                return redirect("account_email_verification_sent")
+                messages.error(self.request,
+                        "Webapp %r belongs to %r but this address is still not verified"
+                        % (docker_name, email_addr.email))
+                return redirect("main:user_need_validation")
 
         # We can import the webapp !
 
@@ -919,6 +921,40 @@ class UserPasswordUpdate(LoginRequiredMixin, SuccessMessageMixin, UpdateView):
         return super(UserPasswordUpdate, self) \
             .dispatch(request, *args, **kwargs)
 
+class UserNeedValidation(LoginRequiredMixin, DetailView):
+    """This page is displayed when the user has not completed the registration process
+
+    Causes:
+    - email address needs verification
+    """
+    template_name = "user_need_validation.html"
+
+    def get_object(self):
+        return None
+
+    def get(self, request):
+        if all(addr.verified for addr in request.user.email_addresses):
+            # redirect to the main page if validation is complete
+            messages.success(request, "Your account is fully validated")
+            return redirect("main:home")
+        else:
+            return super().get(request)
+
+    def post(self, request):
+        # re-send a confirmation e-mail if 'confirm_address_id' is provided
+        try:
+            email_addr = request.user.email_addresses.get(
+                    id=request.POST["confirm_address_id"])
+        except (KeyError, ValueError, ObjectDoesNotExist):
+            pass
+        else:
+            if not email_addr.verified:
+                email_addr.send_confirmation(request)
+                messages.info(self.request, 
+                        "Confirmation e-mail sent to %s" % email_addr.email)
+
+        return redirect(request.path_info)
+
 # JOBS
 # -----------------------------------------------------------------------------
 

django/allgo/templates/user_need_validation.html

+{% extends "base.html" %}
+{% load static htmlattrs socialaccount %}
+
+{% block title %}Account needs validation{% endblock %}
+
+{% block breadcrumb %}
+<li class="breadcrumb-item active" aria-current="page">My profile</li>
+{% endblock %}
+
+{% block content %}
+<div class="container">
+  <div class="allgo-page">
+
+    <div class="pb-3 mb-3">
+      <h2>Your account needs validation</h2>
+    </div>
+    <div>
+      <h5>Email address</h5>
+      <table class="table">
+        <tbody>
+          {% for addr in user.email_addresses %}
+          <tr>
+            <td>{{addr.email}}</td>
+            {% if addr.verified %}
+            <td><i class="text-success">Verified</i></td>
+            <td/>
+              {% else %}
+              <td>
+                <i class="text-danger">Unverified</i>
+              </td>
+              <td>
+                <form class="form-inline mt-0" method="post">
+                  {% csrf_token %}
+                  <input type="hidden" name="confirm_address_id" value="{{addr.id}}"/>
+                  <input class="btn btn-primary" type="submit" value="Re-send verification  e-mail"/>
+                </form>
+              </td>
+              {% endif %}
+          </tr>
+          {% endfor %}
+        </tbody>
+      </table>
+    </div>
+  </div>
+</div>
+{% endblock %}
+
+{% block messages %}
+{{ block.super }}
+{% include 'partials/_form_messages.html' %}
+{% endblock %}
+
+{% block javascript %}
+{{ block.super }}
+<script defer src="{% static 'js/tooltip.js' %}"></script>
+<script defer src="{% static 'js/copy.js' %}"></script>
+{% endblock %}