MAJ terminée. Nous sommes passés en version 14.6.2 . Pour consulter les "releases notes" associées c'est ici :

https://about.gitlab.com/releases/2022/01/11/security-release-gitlab-14-6-2-released/
https://about.gitlab.com/releases/2022/01/04/gitlab-14-6-1-released/

Commit cbc1b247 authored by Mathieu Faverge's avatar Mathieu Faverge
Browse files

Some cleanup for sonarqube

parent e7fb36f3
......@@ -292,7 +292,7 @@ int MORSE_zbuild_Tile_Async( MORSE_enum uplo, MORSE_desc_t *A,
if (chameleon_min( A->m, A->n ) == 0)
return MORSE_SUCCESS;
morse_pzbuild(uplo, A, user_data, user_build_callback, sequence, request);
morse_pzbuild( uplo, A, user_data, user_build_callback, sequence, request );
return MORSE_SUCCESS;
}
......@@ -363,7 +363,7 @@ int MORSE_zgeadd_Tile_Async(MORSE_enum trans,
((alpha == (MORSE_Complex64_t)0.0) && beta == (MORSE_Complex64_t)1.0))
return MORSE_SUCCESS;
morse_pztradd(MorseUpperLower, trans, alpha, A, beta, B, sequence, request);
morse_pztradd( MorseUpperLower, trans, alpha, A, beta, B, sequence, request );
return MORSE_SUCCESS;
}
......@@ -287,10 +287,10 @@ int MORSE_zgelqf_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *T,
#endif
if (morse->householder == MORSE_FLAT_HOUSEHOLDER) {
morse_pzgelqf(A, T, Dptr, sequence, request);
morse_pzgelqf( A, T, Dptr, sequence, request );
}
else {
morse_pzgelqfrh(A, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzgelqfrh( A, T, Dptr, MORSE_RHBLK, sequence, request );
}
if (Dptr != NULL) {
morse_desc_mat_free( Dptr );
......
......@@ -287,7 +287,7 @@ int MORSE_zgelqf_param_Tile_Async(const libhqr_tree_t *qrtree, MORSE_desc_t *A,
}
#endif
morse_pzgelqf_param(qrtree, A, TS, TT, Dptr, sequence, request);
morse_pzgelqf_param( qrtree, A, TS, TT, Dptr, sequence, request );
if (Dptr != NULL) {
morse_desc_mat_free( Dptr );
}
......
......@@ -314,7 +314,7 @@ int MORSE_zgelqs_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *T, MORSE_desc_t *B,
subB = morse_desc_submatrix(B, 0, 0, A->m, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->m, A->m);
morse_pztrsm(MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pztrsm( MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
free(subA);
free(subB);
......@@ -327,10 +327,10 @@ int MORSE_zgelqs_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *T, MORSE_desc_t *B,
#endif
if (morse->householder == MORSE_FLAT_HOUSEHOLDER) {
morse_pzunmlq(MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request);
morse_pzunmlq( MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request );
}
else {
morse_pzunmlqrh(MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzunmlqrh( MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request );
}
if (Dptr != NULL) {
......
......@@ -318,12 +318,12 @@ int MORSE_zgelqs_param_Tile_Async(const libhqr_tree_t *qrtree, MORSE_desc_t *A,
}
*/
/* subB = morse_desc_submatrix(B, A->m, 0, A->n-A->m, B->n);
morse_pzlaset( MorseUpperLower, 0., 0., subB, sequence, request);
morse_pzlaset( MorseUpperLower, 0., 0., subB, sequence, request );
free(subB); */
subB = morse_desc_submatrix(B, 0, 0, A->m, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->m, A->m);
morse_pztrsm(MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pztrsm( MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
free(subA);
free(subB);
......@@ -335,7 +335,7 @@ int MORSE_zgelqs_param_Tile_Async(const libhqr_tree_t *qrtree, MORSE_desc_t *A,
}
#endif
morse_pzunmlq_param(qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request);
morse_pzunmlq_param( qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request );
if (Dptr != NULL) {
morse_desc_mat_free( Dptr );
}
......
......@@ -383,23 +383,23 @@ int MORSE_zgels_Tile_Async(MORSE_enum trans, MORSE_desc_t *A,
#endif
if (morse->householder == MORSE_FLAT_HOUSEHOLDER) {
morse_pzgeqrf(A, T, Dptr, sequence, request);
morse_pzgeqrf( A, T, Dptr, sequence, request );
morse_pzunmqr(MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request);
morse_pzunmqr( MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request );
}
else {
morse_pzgeqrfrh(A, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzgeqrfrh( A, T, Dptr, MORSE_RHBLK, sequence, request );
morse_pzunmqrrh(MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzunmqrrh( MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request );
}
subB = morse_desc_submatrix(B, 0, 0, A->n, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->n, A->n);
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
}
else {
/* subB = morse_desc_submatrix(B, A->m, 0, A->n-A->m, B->n);
morse_pzlaset( MorseUpperLower, 0., 0., subB, sequence, request);
morse_pzlaset( MorseUpperLower, 0., 0., subB, sequence, request );
free(subB); */
#if defined(CHAMELEON_COPY_DIAG)
{
......@@ -409,20 +409,20 @@ int MORSE_zgels_Tile_Async(MORSE_enum trans, MORSE_desc_t *A,
}
#endif
if (morse->householder == MORSE_FLAT_HOUSEHOLDER) {
morse_pzgelqf(A, T, Dptr, sequence, request);
morse_pzgelqf( A, T, Dptr, sequence, request );
}
else {
morse_pzgelqfrh(A, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzgelqfrh( A, T, Dptr, MORSE_RHBLK, sequence, request );
}
subB = morse_desc_submatrix(B, 0, 0, A->m, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->m, A->m);
morse_pztrsm(MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pztrsm( MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
if (morse->householder == MORSE_FLAT_HOUSEHOLDER) {
morse_pzunmlq(MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request);
morse_pzunmlq( MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request );
}
else {
morse_pzunmlqrh(MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzunmlqrh( MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request );
}
}
......
......@@ -393,9 +393,9 @@ int MORSE_zgels_param_Tile_Async(const libhqr_tree_t *qrtree, MORSE_enum trans,
subB = morse_desc_submatrix(B, 0, 0, A->n, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->n, A->n);
morse_pzgeqrf_param(qrtree, A, TS, TT, Dptr, sequence, request);
morse_pzunmqr_param(qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request);
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pzgeqrf_param( qrtree, A, TS, TT, Dptr, sequence, request );
morse_pzunmqr_param( qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request );
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
}
else {
#if defined(CHAMELEON_COPY_DIAG)
......@@ -409,9 +409,9 @@ int MORSE_zgels_param_Tile_Async(const libhqr_tree_t *qrtree, MORSE_enum trans,
subB = morse_desc_submatrix(B, 0, 0, A->m, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->m, A->m);
morse_pzgelqf_param(qrtree, A, TS, TT, Dptr, sequence, request);
morse_pztrsm(MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pzunmlq_param(qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request);
morse_pzgelqf_param( qrtree, A, TS, TT, Dptr, sequence, request );
morse_pztrsm( MorseLeft, MorseLower, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
morse_pzunmlq_param( qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request );
}
free(subA);
......
......@@ -461,7 +461,7 @@ int MORSE_zgemm_Tile_Async(MORSE_enum transA, MORSE_enum transB,
((alpha == (MORSE_Complex64_t)0.0 || K == 0) && beta == (MORSE_Complex64_t)1.0))
return MORSE_SUCCESS;
morse_pzgemm(transA, transB, alpha, A, B, beta, C, sequence, request);
morse_pzgemm( transA, transB, alpha, A, B, beta, C, sequence, request );
return MORSE_SUCCESS;
}
......@@ -286,10 +286,10 @@ int MORSE_zgeqrf_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *T,
#endif
if (morse->householder == MORSE_FLAT_HOUSEHOLDER) {
morse_pzgeqrf(A, T, Dptr, sequence, request);
morse_pzgeqrf( A, T, Dptr, sequence, request );
}
else {
morse_pzgeqrfrh(A, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzgeqrfrh( A, T, Dptr, MORSE_RHBLK, sequence, request );
}
if (Dptr != NULL) {
morse_desc_mat_free( Dptr );
......
......@@ -296,7 +296,7 @@ int MORSE_zgeqrf_param_Tile_Async(const libhqr_tree_t *qrtree, MORSE_desc_t *A,
}
#endif
morse_pzgeqrf_param(qrtree, A, TS, TT, Dptr, sequence, request);
morse_pzgeqrf_param( qrtree, A, TS, TT, Dptr, sequence, request );
if (Dptr != NULL) {
morse_desc_mat_free( Dptr );
......
......@@ -317,15 +317,15 @@ int MORSE_zgeqrs_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *T, MORSE_desc_t *B,
#endif
if (morse->householder == MORSE_FLAT_HOUSEHOLDER) {
morse_pzunmqr(MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request);
morse_pzunmqr( MorseLeft, MorseConjTrans, A, B, T, Dptr, sequence, request );
}
else {
morse_pzunmqrrh(MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request);
morse_pzunmqrrh( MorseLeft, MorseConjTrans, A, B, T, Dptr, MORSE_RHBLK, sequence, request );
}
subB = morse_desc_submatrix(B, 0, 0, A->n, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->n, A->n);
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
free(subA);
free(subB);
......
......@@ -320,8 +320,8 @@ int MORSE_zgeqrs_param_Tile_Async(const libhqr_tree_t *qrtree,
subB = morse_desc_submatrix(B, 0, 0, A->n, B->n);
subA = morse_desc_submatrix(A, 0, 0, A->n, A->n);
morse_pzunmqr_param(qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request);
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request);
morse_pzunmqr_param( qrtree, MorseLeft, MorseConjTrans, A, B, TS, TT, Dptr, sequence, request );
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, subA, subB, sequence, request );
free(subA);
free(subB);
......
......@@ -309,11 +309,11 @@ int MORSE_zgesv_incpiv_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *L, int *IPIV, M
return MORSE_SUCCESS;
*/
morse_pzgetrf_incpiv(A, L, IPIV, sequence, request);
morse_pzgetrf_incpiv( A, L, IPIV, sequence, request );
morse_pztrsmpl(A, B, L, IPIV, sequence, request);
morse_pztrsmpl( A, B, L, IPIV, sequence, request );
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request);
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request );
return MORSE_SUCCESS;
}
......@@ -297,11 +297,11 @@ int MORSE_zgesv_nopiv_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *B,
return MORSE_SUCCESS;
*/
morse_pzgetrf_nopiv(A, sequence, request);
morse_pzgetrf_nopiv( A, sequence, request );
morse_pztrsm(MorseLeft, MorseLower, MorseNoTrans, MorseUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request);
morse_pztrsm( MorseLeft, MorseLower, MorseNoTrans, MorseUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request );
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request);
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request );
return MORSE_SUCCESS;
}
......@@ -282,7 +282,7 @@ int MORSE_zgetrf_incpiv_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *L, int *IPIV,
return MORSE_SUCCESS;
*/
morse_pzgetrf_incpiv(A, L, IPIV, sequence, request);
morse_pzgetrf_incpiv( A, L, IPIV, sequence, request );
return MORSE_SUCCESS;
}
......@@ -265,7 +265,7 @@ int MORSE_zgetrf_nopiv_Tile_Async(MORSE_desc_t *A,
return morse_request_fail(sequence, request, MORSE_ERR_ILLEGAL_VALUE);
}
morse_pzgetrf_nopiv(A, sequence, request);
morse_pzgetrf_nopiv( A, sequence, request );
return MORSE_SUCCESS;
}
......@@ -312,9 +312,9 @@ int MORSE_zgetrs_incpiv_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *L, int *IPIV,
if (chameleon_min(N, NRHS) == 0)
return MORSE_SUCCESS;
*/
morse_pztrsmpl(A, B, L, IPIV, sequence, request);
morse_pztrsmpl( A, B, L, IPIV, sequence, request );
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, A, B, sequence, request);
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, 1.0, A, B, sequence, request );
return MORSE_SUCCESS;
}
......@@ -296,9 +296,9 @@ int MORSE_zgetrs_nopiv_Tile_Async(MORSE_desc_t *A, MORSE_desc_t *B,
if (chameleon_min(N, NRHS) == 0)
return MORSE_SUCCESS;
*/
morse_pztrsm(MorseLeft, MorseLower, MorseNoTrans, MorseUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request);
morse_pztrsm( MorseLeft, MorseLower, MorseNoTrans, MorseUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request );
morse_pztrsm(MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request);
morse_pztrsm( MorseLeft, MorseUpper, MorseNoTrans, MorseNonUnit, (MORSE_Complex64_t)1.0, A, B, sequence, request );
return MORSE_SUCCESS;
}
......@@ -123,7 +123,7 @@ int MORSE_zheevd(MORSE_enum jobz, MORSE_enum uplo, int N,
morse_error("MORSE_zheevd", "illegal value of jobz");
return -1;
}
if (uplo != MorseLower && uplo != MorseUpper) {
if ((uplo != MorseLower) && (uplo != MorseUpper)) {
morse_error("MORSE_zheevd", "illegal value of uplo");
return -2;
}
......@@ -384,7 +384,7 @@ int MORSE_zheevd_Tile_Async( MORSE_enum jobz, MORSE_enum uplo,
morse_error("MORSE_zheevd_Tile_Async", "illegal value of jobz");
return morse_request_fail(sequence, request, MORSE_ERR_ILLEGAL_VALUE);
}
if (uplo != MorseLower && uplo != MorseUpper) {
if ((uplo != MorseLower) && (uplo != MorseUpper)) {
morse_error("MORSE_zheevd_Tile_Async", "illegal value of uplo");
return morse_request_fail(sequence, request, MORSE_ERR_ILLEGAL_VALUE);
}
......@@ -491,7 +491,7 @@ int MORSE_zheevd_Tile_Async( MORSE_enum jobz, MORSE_enum uplo,
morse_pzgemm( MorseNoTrans, MorseNoTrans,
1.0, &descQ2, &descV,
0.0, &descA,
sequence, request);
sequence, request );
}
else {
......@@ -515,7 +515,7 @@ int MORSE_zheevd_Tile_Async( MORSE_enum jobz, MORSE_enum uplo,
morse_pzgemm( MorseNoTrans, MorseNoTrans,
1.0, &descQ2, &descV,
0.0, &descA,
sequence, request);
sequence, request );
}
morse_sequence_wait(morse, sequence);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment