NetworkToolbox issueshttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues2018-03-27T17:35:11+02:00https://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/46Fmin and Fmax in Normalisation should get a better name2018-03-27T17:35:11+02:00COOMAN AdamFmin and Fmax in Normalisation should get a better nameMaybe something like `FMinusOne` and `FPlusOne`Maybe something like `FMinusOne` and `FPlusOne`COOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/45Weird Documentation2018-03-20T18:34:30+01:00MARTINEZ MARTINEZ DavidWeird Documentation```
function [g,w,q] = Forward(obj,f,v,p)
% Forward transform, from the target domain back to the original one
%
% [f,v,p] = Transform.Backward(g,w ,q);
% [f,v,p] = Transform.Ba...```
function [g,w,q] = Forward(obj,f,v,p)
% Forward transform, from the target domain back to the original one
%
% [f,v,p] = Transform.Backward(g,w ,q);
% [f,v,p] = Transform.Backward(g,[],q);
% [f,v] = Transform.Backward(g,w);
%
% where
% g is the function in the transformed domain
% w are the complex numbers in the target domain on which g is evaluated
% q are real numbers which parametrise the w-curve in the complex plane
%
% f is thf function in the original domain
% v are the complex numbers in the original domain on which f is evaluated
% p are real numbers which parametrise the v-curve in the complex plane
```COOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/44Abstract methods not implemented2018-03-15T22:46:50+01:00MARTINEZ MARTINEZ DavidAbstract methods not implemented```
Abstract classes cannot be instantiated. Class 'Normalisation' inherits abstract
methods or properties but does not implement them. See the list of methods and
properties that 'Normalisation' must implement if you do not intend the...```
Abstract classes cannot be instantiated. Class 'Normalisation' inherits abstract
methods or properties but does not implement them. See the list of methods and
properties that 'Normalisation' must implement if you do not intend the class to be
abstract.
```COOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/43Setup instruction2018-01-23T11:16:09+01:00MARTINEZ MARTINEZ DavidSetup instructionI think in the readme it should be noted that the .git folder should not be added to the path... A setup script was not so bat after all...I think in the readme it should be noted that the .git folder should not be added to the path... A setup script was not so bat after all...COOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/42Cannot find an exact (case-sensitive) match for 'MobiusTransform'2018-01-23T11:14:08+01:00MARTINEZ MARTINEZ DavidCannot find an exact (case-sensitive) match for 'MobiusTransform'```
Cannot find an exact (case-sensitive) match for 'MobiusTransform'
The closest match is: mobiusTransform in /home/damartin/MATLAB/NetworkToolbox/source/Transforms/mobiusTransform.m
Error in FRM (line 62)
p.addParame...```
Cannot find an exact (case-sensitive) match for 'MobiusTransform'
The closest match is: mobiusTransform in /home/damartin/MATLAB/NetworkToolbox/source/Transforms/mobiusTransform.m
Error in FRM (line 62)
p.addParameter('Transform',MobiusTransform,@obj.checkTransform);
Error in MultiPort (line 24)
obj@FRM(Data,varargin{:});
Error in MultiPort.read (line 89)
obj = MultiPort(param.Data,param);
```COOMAN AdamCOOMAN Adam2018-01-23https://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/41Farfield has no documentation2018-01-18T22:02:32+01:00COOMAN AdamFarfield has no documentationThe poor class should get at least some explanation.The poor class should get at least some explanation.MARTINEZ MARTINEZ DavidMARTINEZ MARTINEZ Davidhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/40Explain the interface for component functions clearly2018-01-18T14:26:38+01:00COOMAN AdamExplain the interface for component functions clearlyI see that the following call is made to the component functions:
```
[res{1:nargout}] = feval(netlist{nn}{1},'freq',args.frequency,'MultiMatrix',true,netlist{nn}{paramsplit+1:end});
```
The `'MultiMatrix',true` parameter is not explai...I see that the following call is made to the component functions:
```
[res{1:nargout}] = feval(netlist{nn}{1},'freq',args.frequency,'MultiMatrix',true,netlist{nn}{paramsplit+1:end});
```
The `'MultiMatrix',true` parameter is not explained for the moment.
What does it do?MARTINEZ MARTINEZ DavidMARTINEZ MARTINEZ Davidhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/39Explain the algorithm of the interconnect function in the readme2018-01-18T16:59:43+01:00COOMAN AdamExplain the algorithm of the interconnect function in the readmeCOOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/38Add explanation about the derivative to the readme of interconnect2018-01-18T14:19:32+01:00COOMAN AdamAdd explanation about the derivative to the readme of interconnectThe formulas we use and the way the derivatives are provided to the function should be clearly explainedThe formulas we use and the way the derivatives are provided to the function should be clearly explainedMARTINEZ MARTINEZ DavidMARTINEZ MARTINEZ Davidhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/37Make a component of the transmission line2018-01-22T18:06:10+01:00COOMAN AdamMake a component of the transmission lineThe transmission line is a static function of twoport now. It would be better if it were a component, like the components L and C in interconnect.The transmission line is a static function of twoport now. It would be better if it were a component, like the components L and C in interconnect.MARTINEZ MARTINEZ DavidMARTINEZ MARTINEZ Davidhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/36Add multiport junctions2018-01-22T18:19:49+01:00MARTINEZ MARTINEZ DavidAdd multiport junctionsthats itthats ithttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/35Interconnect help2018-01-22T18:17:16+01:00MARTINEZ MARTINEZ DavidInterconnect helpWould it be possible to add in the help of interconnect an explanation of how the function does the interconnection? I mean, the content of the matrices Shuge and Gamma for instance...Would it be possible to add in the help of interconnect an explanation of how the function does the interconnection? I mean, the content of the matrices Shuge and Gamma for instance...COOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/34Interconnect interesting feature2018-01-22T18:17:45+01:00MARTINEZ MARTINEZ DavidInterconnect interesting featureI have a proposal that would be very interesting to implement. I would like that when chaining components, if I provide the gradient of each component, the function return me the gradient of the final object as wellI have a proposal that would be very interesting to implement. I would like that when chaining components, if I provide the gradient of each component, the function return me the gradient of the final object as wellhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/33Broken interconnect2017-11-26T19:09:45+01:00MARTINEZ MARTINEZ DavidBroken interconnectSomething happens, it doesn't workSomething happens, it doesn't workCOOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/32resample should use the new RationalInterpolation functions instead of the Pa...2018-01-17T18:27:36+01:00COOMAN Adamresample should use the new RationalInterpolation functions instead of the Pade interpolation functionsI improved the Pade interpolation functions. The improved functions are called
`RationalInterpolation_EstimateModels` and `RationalInterpolation_EvaluateModels`
The networkToolbox should use those to resample instead of the Pade interp...I improved the Pade interpolation functions. The improved functions are called
`RationalInterpolation_EstimateModels` and `RationalInterpolation_EvaluateModels`
The networkToolbox should use those to resample instead of the Pade interpolationCOOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/31Series L/C does not work (or shunt) with 0 frequency2018-01-22T18:16:47+01:00MARTINEZ MARTINEZ DavidSeries L/C does not work (or shunt) with 0 frequencyMARTINEZ MARTINEZ DavidMARTINEZ MARTINEZ Davidhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/30interconnect does not warn floating nodes.2017-11-13T18:46:28+01:00MARTINEZ MARTINEZ Davidinterconnect does not warn floating nodes.COOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/29MultiMatrix2017-07-09T15:18:00+02:00MARTINEZ MARTINEZ DavidMultiMatrixI'm getting some problems with product of MultiMatrix. Well, in the first place I found that MultiMatrix.run is runing kind of slow in my computer, even with small matrices...
But apart from that I have this:
This is my grad matrix (a m...I'm getting some problems with product of MultiMatrix. Well, in the first place I found that MultiMatrix.run is runing kind of slow in my computer, even with small matrices...
But apart from that I have this:
This is my grad matrix (a matrix of vectors)
```
K>> grad
grad(:,:,1) =
0.0076 -0.0005 0.0082 -0.0006 0.0111 -0.0008 0.0265
grad(:,:,2) =
0.0164 0.0127 0.0189 0.0149 0.0271 0.0215 0.0769
grad(:,:,3) =
0 0 0 0 0 0 0
grad(:,:,4) =
-0.0214 0.0126 -0.0247 0.0148 -0.0351 0.0215 -0.0965
grad(:,:,5) =
0.0164 0.0127 0.0189 0.0149 0.0271 0.0215 0.0769
grad(:,:,6) =
0.1388 -0.0068 0.1622 -0.0085 0.2348 -0.0131 0.6747
grad(:,:,7) =
0.0214 -0.0126 0.0247 -0.0148 0.0351 -0.0215 0.0965
grad(:,:,8) =
0 0 0 0 0 0 0
grad(:,:,9) =
0 0 0 0 0 0 0
grad(:,:,10) =
0.0214 -0.0126 0.0247 -0.0148 0.0351 -0.0215 0.0965
grad(:,:,11) =
0.0076 -0.0005 0.0082 -0.0006 0.0111 -0.0008 0.0265
grad(:,:,12) =
0.0164 0.0127 0.0189 0.0149 0.0271 0.0215 0.0769
grad(:,:,13) =
-0.0214 0.0126 -0.0247 0.0148 -0.0351 0.0215 -0.0965
grad(:,:,14) =
0 0 0 0 0 0 0
grad(:,:,15) =
0.0164 0.0127 0.0189 0.0149 0.0271 0.0215 0.0769
grad(:,:,16) =
0.1388 -0.0068 0.1622 -0.0085 0.2348 -0.0131 0.6747
```
and this is my MultiMatrix:COOMAN AdamCOOMAN Adamhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/28Multiport.write doesn't work2018-01-22T18:07:28+01:00COOMAN AdamMultiport.write doesn't workThe writesnp tries to perform and obj.getS function which doesnt existThe writesnp tries to perform and obj.getS function which doesnt existMARTINEZ MARTINEZ DavidMARTINEZ MARTINEZ Davidhttps://gitlab.inria.fr/acooman/NetworkToolbox/-/issues/27T2017-06-27T11:46:14+02:00MARTINEZ MARTINEZ DavidTI'm getting singular matrix error when setting the T parameters...I'm getting singular matrix error when setting the T parameters...COOMAN AdamCOOMAN Adam